Merged
Conversation
github-actions Bot
added a commit
that referenced
this pull request
Mar 4, 2026
…nder with engaging languages
github-actions Bot
added a commit
that referenced
this pull request
Mar 4, 2026
… name: Gmail sender with engaging languages
IndiaAce
requested changes
Mar 5, 2026
Member
IndiaAce
left a comment
There was a problem hiding this comment.
Hey! Left a comment here for a suggested added change. I've got 2 more notes for changes.
- I went to peak at the escalation to check for some context behind the proposed solution. I know it can seem like a slog to fill those out even for changes like this but any sort of context filling out in those tickets really help out!
- Can you rename the name of this file? I seem to recall approving this when it was 2 rules, but the current name of the rule is no longer in-scope with the logic of the rule.
I'm going to remove this from review-needed feel free to re-add when it's ready :)
Co-authored-by: Luke Wescott <69780712+IndiaAce@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Mar 5, 2026
…lay name: Gmail sender with engaging languages
Member
Author
|
Hey @IndiaAce,
|
IndiaAce
approved these changes
Mar 6, 2026
Member
IndiaAce
left a comment
There was a problem hiding this comment.
Telemetry looks incredible for this, net-new matches are exactly what we want here. Approving!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
Suspicious display name: Gmail sender with engaging language. This rule requires the display_name to contains at least two suspicious words. This PR adds the days of the week and the months to the list.Associated samples
Associated hunts