Skip to content

several UI fix and bug fix #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guoyk93 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

several UI fix and bug fix #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a632a42
backDropView opacity 0.8 is too thick, change to 0.4
yankeguo Feb 20, 2014
9631f05
make picker background color white ; default for iOS 7 is translucency
yankeguo Feb 20, 2014
8aa6db6
logic fix for the situation when initial index is setted before present
yankeguo Feb 20, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BSModalPickerView/BSModalPickerBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

#define BSMODALPICKER_PANEL_HEIGHT 260
#define BSMODALPICKER_TOOLBAR_HEIGHT 44
#define BSMODALPICKER_BACKDROP_OPACITY 0.8
#define BSMODALPICKER_BACKDROP_OPACITY 0.4

#import <UIKit/UIKit.h>

Expand Down
1 change: 1 addition & 0 deletions BSModalPickerView/BSModalPickerBase.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ - (void)presentInView:(UIView *)view withBlock:(BSModalPickerViewCallback)callba
CGRect rect = self.picker.frame;
rect.size.width = self.panel.frame.size.width;
self.picker.frame = rect;
self.picker.backgroundColor = [UIColor whiteColor];
[self.panel addSubview:self.picker];
[self.panel addSubview:self.toolbar];

Expand Down
1 change: 1 addition & 0 deletions BSModalPickerView/BSModalPickerView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ - (void)setValues:(NSArray *)values {
}

- (void)setSelectedIndex:(NSUInteger)selectedIndex {
self.indexSelectedBeforeDismissal = selectedIndex;
if (_selectedIndex != selectedIndex) {
_selectedIndex = selectedIndex;
if (self.picker) {
Expand Down