Skip to content

Fix unsteady testcase configs and add regression tests #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sahilll10 wants to merge 9 commits into
base: develop
Choose a base branch
from
+52 −16
Open

Fix unsteady testcase configs and add regression tests #2755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b83bde8
Fix unsteady testcase configs and add regression tests
Sahilll10 Mar 11, 2026
cd26fb6
Merge branch 'develop' into fix/unsteady-testcase-config-keys
bigfooted Mar 12, 2026
28ef199
Tune inner iteration settings for unsteady test cases
Sahilll10 Mar 16, 2026
b8027b6
Update regression test_vals for new solver settings
Sahilll10 Mar 22, 2026
08962ff
Fix plunging preconditioner and update test_vals to CI build values
Sahilll10 Mar 22, 2026
f203313
Merge branch 'develop' into fix/unsteady-testcase-config-keys
bigfooted Mar 23, 2026
b0d6a94
Add restart file support and update test_vals from developed flow
Sahilll10 Apr 4, 2026
b7d3c8b
Merge branch 'develop' into fix/unsteady-testcase-config-keys
bigfooted Apr 4, 2026
6231759
Fix test_iter to satisfy TIME_ITER > RESTART_ITER constraint
Sahilll10 Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions TestCases/serial_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,6 +819,30 @@ def main():
unst_inc_turb_naca0015_sa.test_vals = [-3.007635, -6.879816, 1.445300, 0.419281]
unst_inc_turb_naca0015_sa.unsteady = True
test_list.append(unst_inc_turb_naca0015_sa)
# unsteady pitching NACA64A010, RANS, SA
unst_pitching_naca64a010_rans = TestCase('unst_pitching_naca64a010_rans')
unst_pitching_naca64a010_rans.cfg_dir = "unsteady/pitching_naca64a010_rans"
unst_pitching_naca64a010_rans.cfg_file = "turb_NACA64A010.cfg"
unst_pitching_naca64a010_rans.test_iter = 2
unst_pitching_naca64a010_rans.test_vals = [-4.799603, -7.374477, -0.005421, 0.008293]
unst_pitching_naca64a010_rans.unsteady = True
test_list.append(unst_pitching_naca64a010_rans)
# unsteady pitching NACA64A010, Euler
unst_pitching_naca64a010_euler = TestCase('unst_pitching_naca64a010_euler')
unst_pitching_naca64a010_euler.cfg_dir = "unsteady/pitching_naca64a010_euler"
unst_pitching_naca64a010_euler.cfg_file = "pitching_NACA64A010.cfg"
unst_pitching_naca64a010_euler.test_iter = 2
unst_pitching_naca64a010_euler.test_vals = [-4.240073, 1.280267, -0.040141, 0.000887]
unst_pitching_naca64a010_euler.unsteady = True
test_list.append(unst_pitching_naca64a010_euler)
# unsteady plunging NACA0012, Laminar NS
unst_plunging_naca0012 = TestCase('unst_plunging_naca0012')
unst_plunging_naca0012.cfg_dir = "unsteady/plunging_naca0012"
unst_plunging_naca0012.cfg_file = "plunging_NACA0012.cfg"
unst_plunging_naca0012.test_iter = 2
unst_plunging_naca0012.test_vals = [-5.829829, -0.258459, 0.888444, -0.124558]
unst_plunging_naca0012.unsteady = True
test_list.append(unst_plunging_naca0012)

# unsteady pitching NACA0012, Euler, Deforming
unst_deforming_naca0012 = TestCase('unst_deforming_naca0012')
Expand Down
16 changes: 10 additions & 6 deletions TestCases/unsteady/pitching_naca64a010_euler/pitching_NACA64A010.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
SOLVER= EULER
KIND_TURB_MODEL= NONE
MATH_PROBLEM= DIRECT
RESTART_SOL= NO
RESTART_SOL= YES

% ------------------------- UNSTEADY SIMULATION -------------------------------%
%
Expand All @@ -26,7 +26,9 @@ TIME_STEP= 0.0023555025613149587
MAX_TIME= 0.59
% 10 periods: 0.5888756403287397
%
INNER_ITER= 110
TIME_DOMAIN= YES
TIME_ITER= 100
INNER_ITER= 20
Comment on lines +29 to +31
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hunk changes INNER_ITER from 110 to 20 in addition to adding TIME_DOMAIN/TIME_ITER. Since the PR description doesn’t mention adjusting INNER_ITER, please confirm the reduction is intentional (e.g., to reduce CI runtime) and document it to avoid silently changing the testcase’s numerical setup.

Copilot uses AI. Check for mistakes.
UNST_ADJOINT_ITER= 251

% ----------------------- DYNAMIC MESH DEFINITION -----------------------------%
Expand Down Expand Up @@ -67,16 +69,15 @@ MARKER_DESIGNING = ( airfoil )
% ------------- COMMON PARAMETERS TO DEFINE THE NUMERICAL METHOD --------------%
%
NUM_METHOD_GRAD= WEIGHTED_LEAST_SQUARES
CFL_NUMBER= 10.0
CFL_NUMBER= 200.0
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CFL_NUMBER is increased from 10.0 to 200.0. This is a significant numerical change and isn’t described in the PR summary; please confirm it’s intentional for this testcase and consider adding a short note in the cfg explaining the choice.

Copilot uses AI. Check for mistakes.
CFL_ADAPT= NO
CFL_ADAPT_PARAM= ( 1.5, 0.5, 1.0, 100.0 )
RK_ALPHA_COEFF= ( 0.66667, 0.66667, 1.000000 )
EXT_ITER= 99999

% ------------------------ LINEAR SOLVER DEFINITION ---------------------------%
%
LINEAR_SOLVER= FGMRES
LINEAR_SOLVER_PREC= LU_SGS
LINEAR_SOLVER_PREC= ILU
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes LINEAR_SOLVER_PREC from LU_SGS to ILU without being mentioned in the PR description. Please confirm this is intentional and add a brief rationale, since it changes the testcase’s solver configuration beyond the unsteady fix.

Copilot uses AI. Check for mistakes.
LINEAR_SOLVER_ERROR= 1E-6
LINEAR_SOLVER_ITER= 5

Expand Down Expand Up @@ -131,7 +132,7 @@ CONV_CAUCHY_EPS= 1E-6
MESH_FILENAME= mesh_NACA64A010_inv.su2
MESH_FORMAT= SU2
MESH_OUT_FILENAME= mesh_out
SOLUTION_FILENAME= restart_flow
SOLUTION_FILENAME= solution_flow
SOLUTION_ADJ_FILENAME= solution_adj
TABULAR_FORMAT= CSV
CONV_FILENAME= history
Expand All @@ -142,10 +143,13 @@ VOLUME_ADJ_FILENAME= adjoint
GRAD_OBJFUNC_FILENAME= of_grad
SURFACE_FILENAME= surface_flow
SURFACE_ADJ_FILENAME= surface_adjoint
SCREEN_OUTPUT= (TIME_ITER, INNER_ITER, RMS_DENSITY, RMS_ENERGY, LIFT, DRAG)
OUTPUT_WRT_FREQ= 250

% --------------------- OPTIMAL SHAPE DESIGN DEFINITION -----------------------%
%
OPT_OBJECTIVE= DRAG * 0.001
OPT_CONSTRAINT= ( LIFT = 0.0 ) * 0.001; ( AREA > 0.0660957 ) * 0.001
DEFINITION_DV= ( 30, 1.0 | airfoil | 0, 0.961538461538 ); ( 30, 1.0 | airfoil | 0, 0.923076923077 ); ( 30, 1.0 | airfoil | 0, 0.884615384615 ); ( 30, 1.0 | airfoil | 0, 0.846153846154 ); ( 30, 1.0 | airfoil | 0, 0.807692307692 ); ( 30, 1.0 | airfoil | 0, 0.769230769231 ); ( 30, 1.0 | airfoil | 0, 0.730769230769 ); ( 30, 1.0 | airfoil | 0, 0.692307692308 ); ( 30, 1.0 | airfoil | 0, 0.653846153846 ); ( 30, 1.0 | airfoil | 0, 0.615384615385 ); ( 30, 1.0 | airfoil | 0, 0.576923076923 ); ( 30, 1.0 | airfoil | 0, 0.538461538462 ); ( 30, 1.0 | airfoil | 0, 0.5 ); ( 30, 1.0 | airfoil | 0, 0.461538461538 ); ( 30, 1.0 | airfoil | 0, 0.423076923077 ); ( 30, 1.0 | airfoil | 0, 0.384615384615 ); ( 30, 1.0 | airfoil | 0, 0.346153846154 ); ( 30, 1.0 | airfoil | 0, 0.307692307692 ); ( 30, 1.0 | airfoil | 0, 0.269230769231 ); ( 30, 1.0 | airfoil | 0, 0.230769230769 ); ( 30, 1.0 | airfoil | 0, 0.192307692308 ); ( 30, 1.0 | airfoil | 0, 0.153846153846 ); ( 30, 1.0 | airfoil | 0, 0.115384615385 ); ( 30, 1.0 | airfoil | 0, 0.0769230769231 ); ( 30, 1.0 | airfoil | 0, 0.0384615384615 ); ( 30, 1.0 | airfoil | 1, 0.0384615384615 ); ( 30, 1.0 | airfoil | 1, 0.0769230769231 ); ( 30, 1.0 | airfoil | 1, 0.115384615385 ); ( 30, 1.0 | airfoil | 1, 0.153846153846 ); ( 30, 1.0 | airfoil | 1, 0.192307692308 ); ( 30, 1.0 | airfoil | 1, 0.230769230769 ); ( 30, 1.0 | airfoil | 1, 0.269230769231 ); ( 30, 1.0 | airfoil | 1, 0.307692307692 ); ( 30, 1.0 | airfoil | 1, 0.346153846154 ); ( 30, 1.0 | airfoil | 1, 0.384615384615 ); ( 30, 1.0 | airfoil | 1, 0.423076923077 ); ( 30, 1.0 | airfoil | 1, 0.461538461538 ); ( 30, 1.0 | airfoil | 1, 0.5 ); ( 30, 1.0 | airfoil | 1, 0.538461538462 ); ( 30, 1.0 | airfoil | 1, 0.576923076923 ); ( 30, 1.0 | airfoil | 1, 0.615384615385 ); ( 30, 1.0 | airfoil | 1, 0.653846153846 ); ( 30, 1.0 | airfoil | 1, 0.692307692308 ); ( 30, 1.0 | airfoil | 1, 0.730769230769 ); ( 30, 1.0 | airfoil | 1, 0.769230769231 ); ( 30, 1.0 | airfoil | 1, 0.807692307692 ); ( 30, 1.0 | airfoil | 1, 0.846153846154 ); ( 30, 1.0 | airfoil | 1, 0.884615384615 ); ( 30, 1.0 | airfoil | 1, 0.923076923077 ); ( 30, 1.0 | airfoil | 1, 0.961538461538 )
READ_BINARY_RESTART= NO
RESTART_ITER= 2
18 changes: 11 additions & 7 deletions TestCases/unsteady/pitching_naca64a010_rans/turb_NACA64A010.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@

% ------------- DIRECT, ADJOINT, AND LINEARIZED PROBLEM DEFINITION ------------%
%
SOLVER= NAVIER_STOKES
SOLVER= RANS
KIND_TURB_MODEL= SA
MATH_PROBLEM= DIRECT
RESTART_SOL= NO
RESTART_SOL= YES

% ------------------------- UNSTEADY SIMULATION -------------------------------%
%
Expand All @@ -27,7 +27,9 @@ TIME_STEP= 0.0023555025613149587
MAX_TIME= 0.59
% 10 periods: 0.5888756403287397
%
INNER_ITER= 2000
TIME_DOMAIN= YES
TIME_ITER= 100
INNER_ITER= 30
Comment on lines +30 to +32
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the unsteady keys, this hunk changes INNER_ITER from 2000 to 30. Since the PR description focuses on TIME_DOMAIN/TIME_ITER/EXT_ITER + solver selection, please confirm the INNER_ITER reduction is intentional and note the motivation (e.g., CI runtime) to avoid surprising changes to the case definition.

Copilot uses AI. Check for mistakes.
UNST_ADJOINT_ITER= 251
GRID_MOVEMENT= RIGID_MOTION
MACH_MOTION= 0.796
Expand Down Expand Up @@ -65,16 +67,15 @@ MARKER_DESIGNING = ( airfoil )
% ------------- COMMON PARAMETERS TO DEFINE THE NUMERICAL METHOD --------------%
%
NUM_METHOD_GRAD= GREEN_GAUSS
CFL_NUMBER= 4.0
CFL_NUMBER= 200.0
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CFL_NUMBER is increased from 4.0 to 200.0. This is a substantial numerical change and isn't called out in the PR description; please confirm it is required/intentional for this testcase (and ideally leave a short in-file comment explaining why this value is appropriate).

Copilot uses AI. Check for mistakes.
CFL_ADAPT= NO
CFL_ADAPT_PARAM= ( 1.5, 0.5, 1.0, 100.0 )
RK_ALPHA_COEFF= ( 0.66667, 0.66667, 1.000000 )
EXT_ITER= 99999

% ------------------------ LINEAR SOLVER DEFINITION ---------------------------%
%
LINEAR_SOLVER= FGMRES
LINEAR_SOLVER_PREC= LU_SGS
LINEAR_SOLVER_PREC= ILU
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes LINEAR_SOLVER_PREC from LU_SGS to ILU without any note in the PR description. Please confirm this is intentional and document the rationale, since it can affect convergence and performance characteristics of the testcase.

Copilot uses AI. Check for mistakes.
LINEAR_SOLVER_ERROR= 1E-6
LINEAR_SOLVER_ITER= 5

Expand Down Expand Up @@ -139,7 +140,7 @@ CONV_CAUCHY_EPS= 1E-5
MESH_FILENAME= mesh_NACA64A010_turb.su2
MESH_FORMAT= SU2
MESH_OUT_FILENAME= mesh_out
SOLUTION_FILENAME= restart_flow
SOLUTION_FILENAME= solution_flow
SOLUTION_ADJ_FILENAME= restart_adj
TABULAR_FORMAT= CSV
CONV_FILENAME= history
Expand All @@ -150,10 +151,13 @@ VOLUME_ADJ_FILENAME= adjoint
GRAD_OBJFUNC_FILENAME= of_grad
SURFACE_FILENAME= surface_flow
SURFACE_ADJ_FILENAME= surface_adjoint
SCREEN_OUTPUT= (TIME_ITER, INNER_ITER, RMS_DENSITY, RMS_NU_TILDE, LIFT, DRAG)
OUTPUT_WRT_FREQ= 1

% --------------------- OPTIMAL SHAPE DESIGN DEFINITION -----------------------%
%
OPT_OBJECTIVE= DRAG * 0.001
OPT_CONSTRAINT= ( AREA > 0.0661121 ) * 0.001
DEFINITION_DV= ( 30, 1.0 | airfoil | 0, 0.961538461538 ); ( 30, 1.0 | airfoil | 0, 0.923076923077 ); ( 30, 1.0 | airfoil | 0, 0.884615384615 ); ( 30, 1.0 | airfoil | 0, 0.846153846154 ); ( 30, 1.0 | airfoil | 0, 0.807692307692 ); ( 30, 1.0 | airfoil | 0, 0.769230769231 ); ( 30, 1.0 | airfoil | 0, 0.730769230769 ); ( 30, 1.0 | airfoil | 0, 0.692307692308 ); ( 30, 1.0 | airfoil | 0, 0.653846153846 ); ( 30, 1.0 | airfoil | 0, 0.615384615385 ); ( 30, 1.0 | airfoil | 0, 0.576923076923 ); ( 30, 1.0 | airfoil | 0, 0.538461538462 ); ( 30, 1.0 | airfoil | 0, 0.5 ); ( 30, 1.0 | airfoil | 0, 0.461538461538 ); ( 30, 1.0 | airfoil | 0, 0.423076923077 ); ( 30, 1.0 | airfoil | 0, 0.384615384615 ); ( 30, 1.0 | airfoil | 0, 0.346153846154 ); ( 30, 1.0 | airfoil | 0, 0.307692307692 ); ( 30, 1.0 | airfoil | 0, 0.269230769231 ); ( 30, 1.0 | airfoil | 0, 0.230769230769 ); ( 30, 1.0 | airfoil | 0, 0.192307692308 ); ( 30, 1.0 | airfoil | 0, 0.153846153846 ); ( 30, 1.0 | airfoil | 0, 0.115384615385 ); ( 30, 1.0 | airfoil | 0, 0.0769230769231 ); ( 30, 1.0 | airfoil | 0, 0.0384615384615 ); ( 30, 1.0 | airfoil | 1, 0.0384615384615 ); ( 30, 1.0 | airfoil | 1, 0.0769230769231 ); ( 30, 1.0 | airfoil | 1, 0.115384615385 ); ( 30, 1.0 | airfoil | 1, 0.153846153846 ); ( 30, 1.0 | airfoil | 1, 0.192307692308 ); ( 30, 1.0 | airfoil | 1, 0.230769230769 ); ( 30, 1.0 | airfoil | 1, 0.269230769231 ); ( 30, 1.0 | airfoil | 1, 0.307692307692 ); ( 30, 1.0 | airfoil | 1, 0.346153846154 ); ( 30, 1.0 | airfoil | 1, 0.384615384615 ); ( 30, 1.0 | airfoil | 1, 0.423076923077 ); ( 30, 1.0 | airfoil | 1, 0.461538461538 ); ( 30, 1.0 | airfoil | 1, 0.5 ); ( 30, 1.0 | airfoil | 1, 0.538461538462 ); ( 30, 1.0 | airfoil | 1, 0.576923076923 ); ( 30, 1.0 | airfoil | 1, 0.615384615385 ); ( 30, 1.0 | airfoil | 1, 0.653846153846 ); ( 30, 1.0 | airfoil | 1, 0.692307692308 ); ( 30, 1.0 | airfoil | 1, 0.730769230769 ); ( 30, 1.0 | airfoil | 1, 0.769230769231 ); ( 30, 1.0 | airfoil | 1, 0.807692307692 ); ( 30, 1.0 | airfoil | 1, 0.846153846154 ); ( 30, 1.0 | airfoil | 1, 0.884615384615 ); ( 30, 1.0 | airfoil | 1, 0.923076923077 ); ( 30, 1.0 | airfoil | 1, 0.961538461538 )
READ_BINARY_RESTART= NO
RESTART_ITER= 2
10 changes: 7 additions & 3 deletions TestCases/unsteady/plunging_naca0012/plunging_NACA0012.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,21 @@
SOLVER= NAVIER_STOKES
KIND_TURB_MODEL= NONE
MATH_PROBLEM= DIRECT
RESTART_SOL= NO
RESTART_SOL= YES

% ------------------------- UNSTEADY SIMULATION -------------------------------%
%
TIME_MARCHING= DUAL_TIME_STEPPING-2ND_ORDER
TIME_STEP= 0.0023555025613149587
TIME_DOMAIN= YES
TIME_ITER= 100
% 24 steps per period: 0.0024536485013697488
% 25 steps per period: 0.0023555025613149587
%
MAX_TIME= 0.5888756403287397
% 10 periods: 0.5888756403287397
%
INNER_ITER= 1000
INNER_ITER= 50
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config change includes runtime/solver-setup modifications beyond the PR description: INNER_ITER is reduced from 1000 to 50. Please confirm this is intentional for the regression/CI version of the case and add a brief rationale (or keep the original value if the intent is only to fix missing unsteady keys).

Copilot uses AI. Check for mistakes.

% ----------------------- DYNAMIC MESH DEFINITION -----------------------------%
%
Expand Down Expand Up @@ -62,7 +64,6 @@ CFL_NUMBER= 1.0
CFL_ADAPT= NO
CFL_ADAPT_PARAM= ( 1.5, 0.5, 1.0, 100.0 )
RK_ALPHA_COEFF= ( 0.66667, 0.66667, 1.000000 )
EXT_ITER= 99999

% ----------------------- SLOPE LIMITER DEFINITION ----------------------------%
%
Expand Down Expand Up @@ -118,4 +119,7 @@ VOLUME_ADJ_FILENAME= adjoint
GRAD_OBJFUNC_FILENAME= of_grad
SURFACE_FILENAME= surface_flow
SURFACE_ADJ_FILENAME= surface_adjoint
SCREEN_OUTPUT= (TIME_ITER, INNER_ITER, RMS_DENSITY, RMS_ENERGY, LIFT, DRAG)
OUTPUT_WRT_FREQ= 1
READ_BINARY_RESTART= NO
RESTART_ITER= 2
Loading