Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
what's the paper? |
pcarruscag
commented
Feb 9, 2026
Comment on lines
+91
to
+98
| /*--- For completeness, the original formulation for the switch to unmodified Steger-Warming is: | ||
| * dp = fabs(P_j - P_i) / fmin(P_j, P_i) | ||
| * w = 0.5 * (1 / (pow(alpha * dp, 2) + 1)) | ||
| * where alpha is a tuning constant to make the scheme switch sooner (large alpha). | ||
| * We're using a version of the switch based on the maximum "dp" over neighbors, from | ||
| * "Development of an Unstructured Navier-Stokes Solver For Hypersonic Nonequilibrium | ||
| * Aerothermodynamics". The 0.06 constant is to match our default alpha (5) to the threshold | ||
| * of 0.3 in the paper. ---*/ |
Contributor
There was a problem hiding this comment.
Also nice to see their solution for the axisymmetry issue.
pcarruscag
commented
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Version of MSW that uses a pressure sensor for switching between SW and MSW instead of just the i and j pressures (which are not very reliable with MUSCL). Also adding the vectorized version.
The paper I had as a reference for MSW mentioned this sensor, and I decided to give it a try.
PR Checklist
pre-commit run --allto format old commits.