Doesn't work on the MUI commonjs modules#365
Open
Janpot wants to merge 1 commit intostyled-components:mainfrom
Open
Doesn't work on the MUI commonjs modules#365Janpot wants to merge 1 commit intostyled-components:mainfrom
Janpot wants to merge 1 commit intostyled-components:mainfrom
Conversation
Open
2 tasks
|
@Janpot , any update on this? |
|
Hello, is there a plan how to fix this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently investigating an issue on
@mui/material+styled-components+next(mui/material-ui#29742). It turns that in the Next.js server bundle, thestyledcalls are not correctly being identified bybabel-plugin-styled-components. The server bundle uses the commonjs version of@mui/material. This PR adds a failing test case for that format.edit: 🤔 The new test doesn't seem to run in CI for some reason