Skip to content
This repository was archived by the owner on Aug 26, 2019. It is now read-only.

Conversation

@mithro
Copy link

@mithro mithro commented Mar 25, 2017

Fixes #1.

Seems to work for me, don't know if this is the best way. I was pondering if the code should extract the source into the llvm directory, but I think this ends up being better.

@stuarteberg
Copy link
Owner

Thanks for looking into this. I've been meaning to update this code to work with conda 2.0 for a while now, but haven't gotten around to it.

I gave your changes a try using a different recipe, in which the "extra" source is a git repo instead of a tarball. On that recipe, it doesn't work. Any ideas?

PS -- just to cross-reference some related discussions:

Ultimately, it would be great if one of us could propose a PR to conda-build itself.

@mithro
Copy link
Author

mithro commented Mar 25, 2017

I'm using it in recipe with git https://github.com/timvideos/conda-hdmi2usb-packages/blob/master/or1k/gcc-newlib/meta.yaml and it works fine for me? Can you include errors?

I haven't tested on Windows/Mac - only Linux...

@mithro
Copy link
Author

mithro commented Mar 29, 2017

I have been able to repo your problem.

The problem is that with a git source (and probably other repository based checkouts) is that the contents end up directly into the work_dir where as normally with a archives you end up with with things inside a directory (but I guess that wouldn't be true for all of them...)

@mithro
Copy link
Author

mithro commented Mar 29, 2017

This interacts very weirdly with the "single directory work dir" - https://github.com/conda/conda-build/blob/master/conda_build/config.py#L509-L513

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants