feat: VersionIcon fixes and improvements#6
Merged
DanielCech merged 5 commits intomasterfrom May 7, 2026
Merged
Conversation
ipek
approved these changes
May 7, 2026
| @@ -1,47 +1,326 @@ | |||
| import AppKit | |||
| import class Foundation.Bundle | |||
| import Foundation | |||
There was a problem hiding this comment.
Now you don't need the line above anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes VersionIcon to work with real asset catalogs instead of a hardcoded legacy icon list, adds configurable error handling with
--onErrorfail|warn, and refactors the implementation into smaller support files for maintainability.Changes
--onErrorfail|warnto allow non-blocking builds when desired--titleRotation.--versionStylevaluesVerification