fix: Force EventNotifier to notify all updates #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the EventNotifier class where Riverpod 3.0's equality-based update filtering was preventing listeners from being notified when the same event was emitted multiple times, particularly affecting navigation scenarios.
Changes:
- Overridden
updateShouldNotifyinEventNotifierto always returntrue, ensuring all event emissions trigger listener notifications regardless of equality - Removed completed TODO item from README.md
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/core/riverpod/event_notifier.dart | Added updateShouldNotify override to force notification on all event emissions |
| README.md | Removed completed TODO items, including the one addressing this EventNotifier fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
updateShouldNotifyto returntruefor cases when user navigates back to the screen and emits the same event. Riverpod starting with version 3.0 compares previous and next events using equal.