Skip to content

Refactoring of hook types #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukaskubanek merged 70 commits into from
Mar 29, 2025
Merged

Refactoring of hook types #3

lukaskubanek merged 70 commits into from
Mar 29, 2025

Conversation

@lukaskubanek
Copy link
Member

@lukaskubanek lukaskubanek commented Mar 25, 2025 •
edited
Loading

  • ...
  • HookStrategy should define target properties (class, selector, scope)
  • HookStrategy.lookUpIMP() -> IMP?
  • Align handling of originalIMP
  • Hook: allow multiple apply() and revert() calls
  • KVO detection in ObjectHookStrategy
  • Hook: clean-up on deinit when not applied (to release the hookIMP)
  • Switch to static methods on Interpose

@lukaskubanek
Reorganized source files
3946944
@lukaskubanek
Replaced XCTest assertion for throwing errors
09e19ee
@lukaskubanek
Reworked HookState
d25ea1d
@lukaskubanek
Centralized deprecated code
5b34576
@lukaskubanek
Marked AnyHook.State as deprecated
8d4e170
@lukaskubanek
Deprecated fluent overloads of apply() and revert()
0c3f4c1
@lukaskubanek
Introduced Hook protocol
5ff2462
@lukaskubanek
Initial step towards strategy-based approach
7b0e94d
@lukaskubanek
Moved originalIMP to AnyHookStrategy
86c05aa
@lukaskubanek
First take on ClassHookStrategy
1fbf432
@lukaskubanek
More tweaks to HookStrategy types
93d756b
@lukaskubanek
Minor tweaks
dee3e0c
@lukaskubanek
Removed guts from ClassHook
d635810
@lukaskubanek
Fixed typos in tests
a68d49d
@lukaskubanek
Raised minimum supported OS versions
8641446
@lukaskubanek
Introduced HookImplementationBuilder
953daaf
@lukaskubanek
Breaking: method and hook signatures have to be explicitly specified
23eb321
@lukaskubanek
Removed HookSignature generic parameter from TypedHook
8fa936e
@lukaskubanek
Introduced HookProxy
da0ea37
@lukaskubanek
Removed MethodSignature generic parameter from TypedHook
1700ad9
@lukaskubanek
Merged TypedHook into AnyHook
f3ae5aa
@lukaskubanek
HookStrategy now conforms to CustomDebugStringConvertible
38a2df1
@lukaskubanek
Merged AnyHook and Hook
59cdbef
@lukaskubanek
Merged remainings of ClassHook into Hook
4127d26
@lukaskubanek
Refactored hook builder & addHook → applyHook
3f7513c
@lukaskubanek
Preps for ObjectHookStrategy
50ce7d4
@lukaskubanek
Preps for ObjectHookStrategy 2/
5510600
@lukaskubanek
Removed generic parameter from ObjectHook
b85ef8e
@lukaskubanek
Moved more code to ObjectHookStrategy
5d781f7
@lukaskubanek
storeHook(…) now works with IMP rather than block
9d1b88b
@lukaskubanek
Hook: Improved file structure
6836949
@lukaskubanek
Tweaks strategy storage
f7956cc
@lukaskubanek
Moved hook-related types to Hook.swift
12b7938
@lukaskubanek
Initial refactoring in InterposeSubclass
56a082a
@lukaskubanek
Improved docs
57d2a7a
@lukaskubanek
Moved files around
b7d3e57
@lukaskubanek
class_setPerceivedClass(for:to:)
b870a22
@lukaskubanek
Tweaks to Hook.originalImp
88ffe00
@lukaskubanek
Initial change to KVO detection
af3e3ac
@lukaskubanek
Tweaked docs for class_setPerceivedClass(…)
2e11338
@lukaskubanek
Formalized KVO check
014c7ed
@lukaskubanek
Marked inherited tests for future polishing
8f603b5
@lukaskubanek
Added test for object_isKVOActive(…)
e2a025a
@lukaskubanek
Sketched out new Interpose facade class
17afb9d
@lukaskubanek
Sketched out new Interpose facade class
8b8978d
@lukaskubanek
Interpose no longer allows apply/revert
c5f4ed9
@lukaskubanek
Moved object validation from Interpose to ObjectHookStrategy
106e139
@lukaskubanek
Deprecated Interpose.init(_:builder:) for classes
209cd30
@lukaskubanek
Deprecated Interpose.init(_:builder:) for objects
d566117
@lukaskubanek
Renamed hook creation methods on Interpose
7901b40
@lukaskubanek
Reworked life cycle handling across the library
a126a31 
- Hook now stores a closure for lazily creating its strategy, replacing the unsafe approach with an implicitly unwrapped optional.
- Hook implementation is now created lazily at the point of applying a hook and released when a hook is reverted, managed in concrete hook strategies.
- Validation in HookStrategy is now performed in a separate step after initialization via `HookStrategy.validate()`.
- ObjectHookStrategy is now referenced weakly from its handle to prevent retain cycles.
- Removed hooks storage in legacy Interpose facade.
- AnyObject → NSObject
@lukaskubanek
Fixed multiline strings
1a50325
@lukaskubanek
Interpose.fail(_:)
c5abecd
@lukaskubanek
Switched Interpose to static methods
334cc6d
@lukaskubanek
Commented out Interpose+Watcher.swift
e834061
@lukaskubanek
Final polish to Interpose facade
5afa11f
@lukaskubanek
Removed irrelevant deprecation
11cfcb0
@lukaskubanek lukaskubanek marked this pull request as ready for review March 29, 2025 10:38
@lukaskubanek lukaskubanek merged commit 8d4bbb3 into main Mar 29, 2025
3 checks passed
@lukaskubanek lukaskubanek deleted the feature/hooks-refactor branch March 29, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukaskubanek