Skip to content

ci: fix docker/setup-qemu-action SHA (v3 tag force-pushed upstream)#50

Merged
polaz merged 2 commits into
mainfrom
ci/#49-fix-qemu-action-pin
May 2, 2026
Merged

ci: fix docker/setup-qemu-action SHA (v3 tag force-pushed upstream)#50
polaz merged 2 commits into
mainfrom
ci/#49-fix-qemu-action-pin

Conversation

@polaz
Copy link
Copy Markdown
Member

@polaz polaz commented May 2, 2026

Summary

  • Updates docker/setup-qemu-action pin from deleted SHA 29109295 to c7c53464 (v3.7.0)
  • SHA 29109295 was removed when the upstream v3 tag was force-pushed; GitHub Actions fails to resolve it even for steps with if: conditions

Closes #49

Previous SHA 29109295 was deleted/force-pushed upstream;
GitHub Actions fails to resolve it even for skipped steps.

Updated to c7c53464 (v3.7.0) which is the current stable ref.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 737f446d-1323-460d-a8c0-191bd8eb0cc5

📥 Commits

Reviewing files that changed from the base of the PR and between 1306626 and d943955.

⛔ Files ignored due to path filters (1)
  • coordinode-embedded/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • coordinode-embedded/.gitignore
💤 Files with no reviewable changes (1)
  • coordinode-embedded/.gitignore

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated embedded build setup to use a newer QEMU setup for improved build stability.
    • Adjusted repository ignore rules to exclude the embedded build output directory.
    • No user-facing functionality changes in this release.

Walkthrough

Release workflow now pins docker/setup-qemu-action to v3.7.0 instead of the v3 tag; separately, coordinode-embedded/.gitignore adds target/ and removes the explicit Cargo.lock ignore.

Changes

GitHub Actions: QEMU action pin

Layer / File(s) Summary
Workflow Config
.github/workflows/release.yml
Set up QEMU step updated: docker/setup-qemu-action ref changed from v3 (previously resolved to a broken SHA) to the pinned v3.7.0.

Embedded repo ignore rules

Layer / File(s) Summary
Ignore rules
coordinode-embedded/.gitignore
Added target/ and removed the explicit Cargo.lock ignore entry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The .gitignore modification (removing Cargo.lock ignore, adding target/ ignore) appears unrelated to the stated objective of fixing the GitHub Actions workflow reference. The .gitignore changes should be moved to a separate PR focused on build artifact management, or clarify their relationship to the docker/setup-qemu-action fix if intentional.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the docker/setup-qemu-action SHA reference due to upstream tag force-push.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation for updating the QEMU action reference and the specific SHAs involved.
Linked Issues check ✅ Passed The PR successfully addresses issue #49 by updating the docker/setup-qemu-action SHA from the deleted 29109295 to c7c53464 (v3.7.0) as required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/#49-fix-qemu-action-pin

Review rate limit: 3/5 reviews remaining, refill in 20 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Cargo.lock was gitignored, allowing cargo to resolve openraft
0.10.0-alpha.18/19 which changed NetBackoff::backoff() signature.
Committing the lock pins all transitive deps to the versions
compatible with the coordinode-rs submodule at v0.4.1.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 2, 2026

@polaz polaz merged commit f53c19a into main May 2, 2026
8 checks passed
@polaz polaz deleted the ci/#49-fix-qemu-action-pin branch May 2, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: fix docker/setup-qemu-action SHA (v3 tag force-pushed upstream)

1 participant