[Requires iOS SDK Update] Makes LinkAppearance.PrimaryButtonConfiguration Mapping Consistent With Android#2475
Draft
mliberatore wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on stripe/stripe-ios#6510 and a subsequent iOS SDK update.
Previously, unspecified values on
initmadePrimaryButtonConfiguration's properties default to.zero. This led to a mismatch in mapping behavior since the properties couldn’t benil, and individually apply corner radius or height, falling back to Link defaults for the other.Motivation
This comment: #2404 (comment)
Testing
Ensured we were able to set each value independently while relying on a default for the other. I used intentionally obvious values to ensure they were being applied, and differed from sensible defaults.
Documentation
Select one: