fix: Fix game settings specific filters not doing anything#3179
Open
ferafiks wants to merge 4 commits into
Open
fix: Fix game settings specific filters not doing anything#3179ferafiks wants to merge 4 commits into
ferafiks wants to merge 4 commits into
Conversation
…ter aren't used as the default on all devices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Previously, the specific filters in the game settings asset didn't do anything. This PR fixes that.
Originally, there were two static fields in
PlatformConfigurationthat were never set:RendererNameandDeviceModel. From what I assume, the former was meant to be the graphics adapter description (which now is being set) and the latter, the CPU model. I couldn't find a place where Stride stores the CPU name, so I removed it.This PR also changes the previous unimplemented behavior: instead of trying to find the first matching configuration from a certain group (default, only platform filters, platform filters + specific filters), the engine now tries to find the last one.
Types of changes
Checklist