fix: Prevent Game Studio crash when creating prefab from entities with ModelNodeLinkComponent#3167
Open
w0wca7a wants to merge 2 commits into
Open
fix: Prevent Game Studio crash when creating prefab from entities with ModelNodeLinkComponent#3167w0wca7a wants to merge 2 commits into
w0wca7a wants to merge 2 commits into
Conversation
fix exception when entity has not been re-parented yet
fix null model when CheckSkeleton() triggered. model reference is restored later in the reconcile pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Fixes two NullReferenceException crashes that occur when creating a prefab from a selection that contains entities with a ModelNodeLinkComponent bound to a skeleton node.
Related Issue
fix #3165
Types of changes
Checklist