Prevent typeless textures from creating srv / rtv on initialization#3095
Open
johang88 wants to merge 1 commit intostride3d:masterfrom
Open
Prevent typeless textures from creating srv / rtv on initialization#3095johang88 wants to merge 1 commit intostride3d:masterfrom
johang88 wants to merge 1 commit intostride3d:masterfrom
Conversation
Member
|
Probably we should do the same for D3D12 (and maybe Vulkan if it works the same)? |
Contributor
Author
|
Good point, I'll have to check how they behave. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
DirectX 11 does not allow Shader Resource Views or Render Target Views to be created for typeless textures. This change prevents their creation upon texture initialization, which would have given an exception when
NativeDevice.CreateShaderResourceView/NativeDevice.CreateRenderTargetViewwere called. Users can then create views in their desired format usingToTextureView.Example usage from when I had to interpret the same texture as both SRgb and non SRgb, typeless is required here as creating a non srgb view from an srgb texture is not allowed.
Types of changes
Checklist