Integration gh workflow for test install and uninstall#6
Conversation
tomncooper
left a comment
There was a problem hiding this comment.
A few nits and I wonder if it would be better to have the longer validation and debugging steps be scripts so that they could be parametrised in future when we add additional overlays with different component mixes.
Signed-off-by: David Kornel <kornys@outlook.com>
Signed-off-by: David Kornel <kornys@outlook.com>
Signed-off-by: David Kornel <kornys@outlook.com>
|
@tomncooper I have implemented your suggestions. |
tomncooper
left a comment
There was a problem hiding this comment.
LGTM, I think we might need a more generic way to work out what is in each overlay directly from the kustomization files, but that can be added later.
There was a problem hiding this comment.
It is nice to have this separated out, but there are other elements (like the install and uninstall scripts) that need the overlay details. So I wonder if it would be possible to do this programmatically by looking at the kustomizations.
However, that is premature optimization and once we merge this we can look at other options.
Uh oh!
There was an error while loading. Please reload this page.