Skip to content

Integration gh workflow for test install and uninstall#6

Merged
kornys merged 3 commits intomainfrom
integration-wf
Mar 24, 2026
Merged

Integration gh workflow for test install and uninstall#6
kornys merged 3 commits intomainfrom
integration-wf

Conversation

@kornys
Copy link
Copy Markdown
Member

@kornys kornys commented Mar 19, 2026

  1. Fix for Apicurio operator namespace watch cannot be "*" but has to be empty
  2. Added workflow with Minikube (+ ingress) for install/check/uninstall
  3. Added workglow with Kind (+ingress) for install/check/uninstall

@kornys kornys self-assigned this Mar 19, 2026
@kornys kornys marked this pull request as ready for review March 19, 2026 20:31
@kornys kornys requested review from Frawless and tomncooper March 19, 2026 20:31
@kornys kornys linked an issue Mar 19, 2026 that may be closed by this pull request
@kornys kornys requested a review from Frawless March 20, 2026 07:50
Copy link
Copy Markdown
Contributor

@tomncooper tomncooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits and I wonder if it would be better to have the longer validation and debugging steps be scripts so that they could be parametrised in future when we add additional overlays with different component mixes.

kornys added 2 commits March 23, 2026 13:54
Signed-off-by: David Kornel <kornys@outlook.com>
Signed-off-by: David Kornel <kornys@outlook.com>
Signed-off-by: David Kornel <kornys@outlook.com>
@kornys kornys requested a review from tomncooper March 23, 2026 20:00
@kornys
Copy link
Copy Markdown
Member Author

kornys commented Mar 24, 2026

@tomncooper I have implemented your suggestions.

Copy link
Copy Markdown
Contributor

@tomncooper tomncooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we might need a more generic way to work out what is in each overlay directly from the kustomization files, but that can be added later.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nice to have this separated out, but there are other elements (like the install and uninstall scripts) that need the overlay details. So I wonder if it would be possible to do this programmatically by looking at the kustomizations.

However, that is premature optimization and once we merge this we can look at other options.

@kornys kornys merged commit 184f6bf into main Mar 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation smoke tests

3 participants