fix: avoid omitting boolean values when serializing#389
Open
DavidLindbom wants to merge 1 commit intostreamnative:mainfrom
Open
fix: avoid omitting boolean values when serializing#389DavidLindbom wants to merge 1 commit intostreamnative:mainfrom
DavidLindbom wants to merge 1 commit intostreamnative:mainfrom
Conversation
ThomasVerhoeven1998
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374
Motivation
When setting topicAutoCreationConfig.allow: false on a PulsarNamespace resource the operator updates the object with the field removed which causes our gitops tool to reapply the field. Over and over again.
Modifications
Removed
omitemptyfor all boolean fields.Verifying this change
This change added tests and can be verified as follows:
Documentation
no-need-docThe patch is not a functional change.