Add Istio ambient mode support to Helm chart#1254
Merged
fantapsody merged 1 commit intomasterfrom Nov 19, 2025
Merged
Conversation
This commit adds support for Istio ambient mode (sidecar-less data plane) to all Pulsar components in the Helm chart, following the design from sn-operator/docs/proposals/istio-ambient-mode-design.md. Changes: - Add dataplaneMode field to values.yaml istio section (defaults to empty for backward compatibility) - Update PulsarBroker template to include dataplaneMode in istio config - Update PulsarProxy template to include dataplaneMode in istio config - Add istio section with dataplaneMode to BookKeeperCluster template - Add istio section with dataplaneMode to ZooKeeperCluster template Benefits: - Backward compatible (empty value defaults to sidecar mode via API) - Enables ~70-80% resource savings with ambient mode - Supports migration mode with permissive mTLS - All components (Broker, Proxy, BookKeeper, ZooKeeper) support ambient mode Usage: Set istio.dataplaneMode: "ambient" to enable sidecar-less data plane Set istio.dataplaneMode: "sidecar" or leave empty for traditional sidecar mode 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
@fantapsody:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
|
@fantapsody:Thanks for providing doc info! |
github-actions
bot
added
no-need-doc
tuteng
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for Istio ambient mode (sidecar-less data plane) to all Pulsar components in the Helm chart, following the design from sn-operator/docs/proposals/istio-ambient-mode-design.md.
Changes:
Benefits:
Usage:
Set istio.dataplaneMode: "ambient" to enable sidecar-less data plane Set istio.dataplaneMode: "sidecar" or leave empty for traditional sidecar mode
🤖 Generated with Claude Code
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)