Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurable security contexts and resource limits for init containers in the zookeeper and bookkeeper components. The changes allow users to specify separate security settings for init containers, distinct from the main container security contexts, and enable resource allocation for bookkeeper init containers.
- Adds
initContainerSecurityContextconfiguration options to zookeeper and bookkeeper in both platform charts - Applies security context to zookeeper restore init containers
- Applies security context and resource limits to bookkeeper metadata cleanup init containers
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/sn-platform/values.yaml | Adds initContainerSecurityContext configuration fields for zookeeper and bookkeeper |
| charts/sn-platform/templates/zookeeper/zookeeper-cluster.yaml | Applies security context to zookeeper restore init container |
| charts/sn-platform/templates/bookkeeper/bookkeeper-cluster.yaml | Applies security context and resources to bookkeeper metadata cleanup init container |
| charts/sn-platform-slim/values.yaml | Adds initContainerSecurityContext configuration fields for zookeeper and bookkeeper |
| charts/sn-platform-slim/templates/zookeeper/zookeeper-cluster.yaml | Applies security context to zookeeper restore init container |
| charts/sn-platform-slim/templates/bookkeeper/bookkeeper-cluster.yaml | Applies security context and resources to bookkeeper metadata cleanup init container |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@labuladong:Thanks for your contribution. For this PR, do we need to update docs? |
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)