Add authorization policy to components#1249
Conversation
|
@labuladong:Thanks for your contribution. For this PR, do we need to update docs? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurable Istio AuthorizationPolicy support to multiple platform components, enabling fine-grained access control through customizable from and to sections while maintaining backward compatibility with existing default port configurations.
Key Changes:
- Added
authorizationPolicyconfiguration blocks (withfromandtofields) to values.yaml for functions, pulsar_detector, proxy, toolset, prometheus, and grafana components - Updated authorization policy templates to conditionally use custom configurations when provided, falling back to existing defaults when not specified
- Created new authorization policy template for the toolset component
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/sn-platform/values.yaml | Added authorizationPolicy configuration blocks with documentation and examples for functions, pulsar_detector, proxy, toolset, prometheus, and grafana |
| charts/sn-platform-slim/values.yaml | Added identical authorizationPolicy configuration blocks for the slim variant |
| charts/sn-platform/templates/*/*-authorizationpolicy.yaml | Updated 7 templates to support custom from/to configurations with fallback to defaults |
| charts/sn-platform-slim/templates/*/*-authorizationpolicy.yaml | Updated 5 templates in slim variant to match sn-platform changes |
| charts/sn-platform*/templates/toolset/toolset-authorizationpolicy.yaml | Created new authorization policy templates for toolset component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)