Avoid nil pointer for authorizationPolicy#1246
Merged
labuladong merged 1 commit intomasterfrom Oct 22, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds nil pointer safety checks to authorization policy templates across multiple Helm charts by verifying that the parent authorizationPolicy object exists before accessing its child properties (from and to).
Key Changes:
- Added parent object existence checks using
andoperator in conditional statements - Applied consistently across zookeeper, broker, bookkeeper, and autorecovery authorization policy templates
- Prevents template rendering errors when
authorizationPolicyis nil/undefined
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/sn-platform/templates/zookeeper/zookeeper-authorizationpolicy.yaml | Added nil checks for zookeeper.authorizationPolicy before accessing .from and .to |
| charts/sn-platform/templates/broker/broker-authorizationpolicy.yaml | Added nil checks for broker.authorizationPolicy before accessing .from and .to |
| charts/sn-platform/templates/bookkeeper/bookkeeper-authorizationpolicy.yaml | Added nil checks for bookkeeper.authorizationPolicy and autorecovery.authorizationPolicy before accessing .from and .to |
| charts/sn-platform-slim/templates/zookeeper/zookeeper-authorizationpolicy.yaml | Added nil checks for zookeeper.authorizationPolicy before accessing .from and .to |
| charts/sn-platform-slim/templates/broker/broker-authorizationpolicy.yaml | Added nil checks for broker.authorizationPolicy before accessing .from and .to |
| charts/sn-platform-slim/templates/bookkeeper/bookkeeper-authorizationpolicy.yaml | Added nil checks for bookkeeper.authorizationPolicy and autorecovery.authorizationPolicy before accessing .from and .to |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@labuladong:Thanks for your contribution. For this PR, do we need to update docs? |
tuteng
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly set to null will cause NPE.