Fixing Dual Output vertical audio#1694
Merged
Merged
Conversation
…kFactory and into each advanced output
sandboxcoder
approved these changes
May 11, 2026
summeroff
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes advanced streaming/recording/replay-buffer outputs to create their own per-output audio encoders from user-visible track configuration.
This PR fixes audio issues for the Vertical canvas when using dual output via Factory API.
Motivation and Context
The main behavioral goal is to allow multiple advanced outputs, such as horizontal and vertical streams or future simultaneous horizontal/vertical recordings, to use the same user audio track without relying on a "hidden" track
2indesktopor sharing one global OBS audio encoder object.Changes
AudioTrackno longer owns an OBS encoder.It now represents only user-visible advanced track configuration:
AdvancedStreaminghas its own audio encoderWhen starting, it validates the configured track, then creates or reuses a private encoder for that output. This means two advanced streams can use the same user-level audio track without sharing the same native encoder object.
The destructor now releases the streaming-owned audio encoder reference after deleting the output. If the encoder is unexpectedly still active, it logs a warning before releasing the owner reference.
AdvancedRecordingandAdvancedReplayBuffer.How Has This Been Tested?
Manually, Windows only.
Types of changes