Skip to content

Fixing Dual Output vertical audio#1694

Merged
aleksandr-voitenko merged 1 commit into
stagingfrom
dual-output-audio-encoder-tracks
May 11, 2026
Merged

Fixing Dual Output vertical audio#1694
aleksandr-voitenko merged 1 commit into
stagingfrom
dual-output-audio-encoder-tracks

Conversation

@aleksandr-voitenko
Copy link
Copy Markdown
Collaborator

@aleksandr-voitenko aleksandr-voitenko commented May 11, 2026

Description

This PR changes advanced streaming/recording/replay-buffer outputs to create their own per-output audio encoders from user-visible track configuration.

This PR fixes audio issues for the Vertical canvas when using dual output via Factory API.

Motivation and Context

The main behavioral goal is to allow multiple advanced outputs, such as horizontal and vertical streams or future simultaneous horizontal/vertical recordings, to use the same user audio track without relying on a "hidden" track 2 in desktop or sharing one global OBS audio encoder object.

Changes

  1. AudioTrack no longer owns an OBS encoder.

It now represents only user-visible advanced track configuration:

  • bitrate
  • name
  1. AdvancedStreaming has its own audio encoder
    When starting, it validates the configured track, then creates or reuses a private encoder for that output. This means two advanced streams can use the same user-level audio track without sharing the same native encoder object.

The destructor now releases the streaming-owned audio encoder reference after deleting the output. If the encoder is unexpectedly still active, it logs a warning before releasing the owner reference.

  1. The same is applied to AdvancedRecording and AdvancedReplayBuffer.

How Has This Been Tested?

Manually, Windows only.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

@aleksandr-voitenko aleksandr-voitenko changed the title Fixing Dual Output audio Fixing Dual Output Vertical audio May 11, 2026
@aleksandr-voitenko aleksandr-voitenko changed the title Fixing Dual Output Vertical audio Fixing Dual Output vertical audio May 11, 2026
@aleksandr-voitenko aleksandr-voitenko merged commit 7df3538 into staging May 11, 2026
72 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants