Support when running with frozen string literals #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Earlopain i know this is old, but more relevant with 3.4 now. I was just about to submit a PR, then saw yours pending. Same exact change, so can verify fix if anyone maintaining their own forks, or future 3.4 users that end up here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUBYOPT=--enable=frozen-string-literal bundle exec rspecRuby is once again going in the direction of freezing strings by default. This is all that's needed here to make it compatible, at least according the the test suite and what I make use of from the gem myself.
I don't really expect this to be merged, the project looks pretty dead to me but maybe someone else will find this useful.