Add per-field UpdateOp support for advanced database operations #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds UpdateOp enum to Field proto message enabling per-field update semantics: - Set: Direct assignment (default, existing behavior) - Add: Accumulate values (col = COALESCE(col, 0) + value) - Max: Track maximum (col = GREATEST(col, value)) - Min: Track minimum (col = LEAST(col, value)) - SetIfNull: First-write-wins (col = COALESCE(col, value)) New row helper methods: set(), add(), sub(), max(), min(), set_if_null() Includes strict transition validation - once a non-SET op is used on a field, only the same op type can follow (e.g., add() -> add() OK, add() -> max() PANIC).
Previously min() and max() functions would just overwrite the existing value, delegating the LEAST/GREATEST logic to the sink. This caused issues when set() was followed by min()/max() in the same block - the initial value set by set() would be lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UpdateOp enum to Field proto message enabling per-field update semantics:
New row helper methods: set(), add(), sub(), max(), min(), set_if_null()
Includes strict transition validation - once a non-SET op is used on a field, only the same op type can follow (e.g., add() -> add() OK, add() -> max() PANIC).