Skip to content

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Dec 16, 2025

Related #379

@mulkieran mulkieran self-assigned this Dec 16, 2025
@mulkieran
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2025

Walkthrough

A new release notes document for Stratis 3.8.2 is added, detailing features and behavior changes including key management for encrypted pools, automatic key loading mechanisms, a new DBus property VolumeKeyLoaded, and CLI alert behavior for V2 encrypted pools.

Changes

Cohort / File(s) Summary
Stratis 3.8.2 Release Notes
content/stratis-release-notes-3.8.2.md
New release notes document with metadata and detailed changelog covering stratisd 3.8.2 and stratis-cli 3.8.2, including key management features, DBus properties, and CLI behavior updates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Factual accuracy verification: Confirm details about key management, VolumeKeyLoaded property states, and CLI behavior align with actual release changes
  • Formatting consistency: Ensure metadata fields (title, date, weight, template, render) follow site conventions
  • Documentation references: Validate links and references to upstream changelogs and related documentation

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Stratis 3.8.2 release notes' directly and clearly describes the main change—adding release notes documentation for Stratis 3.8.2, which aligns perfectly with the changeset content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6668f3 and e82ac95.

📒 Files selected for processing (1)
  • content/stratis-release-notes-3.8.2.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
content/stratis-release-notes-3.8.2.md

[grammar] ~23-~23: Use a hyphen to join words.
Context: ...stopped. stratisd now supports a pool level DBus property, VolumeKeyLoaded, ...

(QB_NEW_EN_HYPHEN)


[style] ~25-~25: In contexts where ‘if’ is followed by ‘or’, using ‘whether’ may be more appropriate (and formal).
Context: ...y, VolumeKeyLoaded, which is: * false if the pool is a V1 pool or not encrypted ...

(IF_WHETHER)

🪛 markdownlint-cli2 (0.18.1)
content/stratis-release-notes-3.8.2.md

9-9: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🔇 Additional comments (1)
content/stratis-release-notes-3.8.2.md (1)

1-51: Release notes content looks well-structured and clear.

The document effectively explains the new key management features in Stratis 3.8.2, provides clear descriptions of the VolumeKeyLoaded property behavior, documents subsequent patch releases and their purposes, and links to upstream changelogs for additional details. The formatting and flow are appropriate for release notes documentation.

@mulkieran mulkieran force-pushed the issue_stratis-docs_379 branch from e82ac95 to c8b187c Compare December 16, 2025 01:38
@mulkieran mulkieran moved this to In Review in 2025December Dec 16, 2025
@mulkieran mulkieran force-pushed the issue_stratis-docs_379 branch 2 times, most recently from 846ac14 to 295a79b Compare December 16, 2025 01:46
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran merged commit 1001e6a into stratis-storage:master Dec 16, 2025
5 checks passed
@mulkieran mulkieran deleted the issue_stratis-docs_379 branch December 16, 2025 20:35
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025December Dec 16, 2025
@mulkieran mulkieran moved this from Done to Done(2) in 2025December Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done(2)

Development

Successfully merging this pull request may close these issues.

3 participants