Skip to content

Match org.freedesktop.zbus.Error in error reporting #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mulkieran wants to merge 2 commits into from
Closed

Match org.freedesktop.zbus.Error in error reporting #1251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33454bf
Only match org.freedesktop.zbus.Error for property setting
mulkieran Jan 6, 2026
a30484d
TEMPORARY: remove manual trigger
mulkieran Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .packit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:
- job: copr_build
trigger: pull_request
identifier: copr_pull
manual_trigger: true
targets:
- fedora-all

Expand Down
11 changes: 1 addition & 10 deletions src/stratis_cli/_error_reporting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def _interpret_errors_2( # pylint: disable=too-many-return-statements

if dbus_name == "org.freedesktop.zbus.Error" and isinstance(
context, DPClientSetPropertyContext
): # pragma: no cover
):
return (
f"stratisd failed to perform the operation that you "
f"requested, because it could not set the D-Bus "
Expand Down Expand Up @@ -335,15 +335,6 @@ def _interpret_errors_2( # pylint: disable=too-many-return-statements
f"service sent the following message: {dbus_message}."
)

if isinstance(context, DPClientSetPropertyContext): # pragma: no cover
return (
f"stratisd failed to perform the operation that you "
f"requested, because it could not set the D-Bus "
f'property "{context.property_name}" belonging to '
f'interface "{error.interface_name}" to "{context.value}". '
f"It returned the following error: {dbus_message}."
)

if isinstance(context, DPClientGetPropertyContext): # pragma: no cover
return (
f"stratisd failed to perform the operation that you "
Expand Down
Loading