Rename identifier for clarity

[mulkieran]

Related #1225

Summary by CodeRabbit

• Refactor
  • Standardized naming for the mapping between pool object paths and pool names across the filesystem listing flow.
  • Updated constructors and related components to use the new, clearer parameter name consistently.
  • No changes to CLI behavior, output, or user workflows; this is a clarity/maintainability improvement only.

[coderabbitai]

Walkthrough

Renamed the public mapping parameter and attribute from path_to_name to pool_object_path_to_pool_name across listing logic in src/stratis_cli/_actions/_list_filesystem.py, updating constructor signatures for Table and ListFilesystem and all internal references, while preserving existing behavior.

Changes

Cohort / File(s)	Summary of Changes
Parameter rename for pool mapping src/stratis_cli/_actions/_list_filesystem.py	Renamed constructor parameter path_to_name → pool_object_path_to_pool_name in Table and ListFilesystem; updated attribute self.path_to_name → self.pool_object_path_to_pool_name; adjusted call sites (list_filesystems) and internal references in Table/Detail to use the new name.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at names that change,
Hop-hop, I map the paths anew—how strange!
Pools and paths now neatly align,
Same carrots, different bowl—still fine.
With gentle thumps, I sign my claim:
A tidy warren, just a new name. 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "Rename identifier for clarity" accurately describes the main change in the changeset, which is the renaming of the path_to_name parameter and attribute to pool_object_path_to_pool_name throughout the filesystem listing code. The title clearly conveys that this is a renaming operation performed to improve code clarity. While the title doesn't specify which identifier is being renamed, it appropriately summarizes the nature and intent of the change, which is a focused refactoring to make the code more understandable.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 423ae20 and 067659d.

📒 Files selected for processing (1)

• src/stratis_cli/_actions/_list_filesystem.py (6 hunks)

🔇 Additional comments (7)

src/stratis_cli/_actions/_list_filesystem.py (7)

61-64: LGTM! Improved naming clarity.

The new name pool_object_path_to_pool_name is significantly more descriptive than path_to_name, making it clear that this maps pool object paths to pool names.

---

77-77: LGTM! Consistent parameter passing.

The parameter name is correctly updated to match the renamed variable.

---

83-83: LGTM! Consistent parameter passing.

The parameter name is correctly updated to match the renamed variable.

---

108-108: LGTM! Consistent attribute naming.

The instance attribute is correctly updated to match the renamed parameter.

---

144-144: LGTM! Consistent usage update.

The attribute reference is correctly updated in the Table display logic.

---

190-190: LGTM! Consistent usage update.

The attribute reference is correctly updated in the Detail display logic.

---

94-99: The parameter rename does not affect external code.

The verification confirms that Table and Detail are only instantiated within the same file (lines 74 and 80), and both instantiations already use the new parameter name pool_object_path_to_pool_name. The ListFilesystem base class is not used outside this file. The path_to_name reference found in _physical.py is an unrelated local variable. Since there are no external callers, this is not a breaking change.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

• Public repositories are always opted into early access features.
• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}