Skip to content

Use dynamic build for Manager class #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mulkieran wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Use dynamic build for Manager class #1042

mulkieran wants to merge 14 commits into from

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Nov 27, 2023 •
edited
Loading

Related #1033

@mulkieran mulkieran self-assigned this Nov 27, 2023
@mulkieran mulkieran force-pushed the issue_stratis-cli_1033 branch 2 times, most recently from f60cbfb to b166f92 Compare November 27, 2023 18:58
@mulkieran
Copy link
Member Author

mulkieran commented Nov 27, 2023 •
edited
Loading

make_dyn_class should memo-ize the dynamically generated classes, and should take a list of keys.

@mulkieran mulkieran force-pushed the issue_stratis-cli_1033 branch 5 times, most recently from 3cb269c to 69828b1 Compare November 28, 2023 14:25
@mulkieran
Copy link
Member Author

mulkieran commented Nov 28, 2023

The invocations of make_dyn_class are too wordy. They should be super simple, just one arg which very closely resembles the class name. make_dyn_class should then interpret that one argument.

@mulkieran
Build, do not import dynamically generated classes
51f0341 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
comment
02ca9b0
@mulkieran
Use another class for class generation
7a93fbc 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Add method modifications
c4d4c50 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the issue_stratis-cli_1033 branch from 69828b1 to 93c34b1 Compare November 29, 2023 19:50
@mulkieran
More things
398ae7c 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Use purpose argument
13cc0c3 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Temporary no cover
61d09fd 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Simplify
ca36488 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Memoize
a85e95c 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Add no cover temporarily
456d6e4 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Use an anonymous function to get the interface specification
20e4e26 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the issue_stratis-cli_1033 branch from 0f77dff to 20e4e26 Compare December 4, 2023 15:11
@mulkieran
Copy link
Member Author

mulkieran commented Dec 4, 2023

Need to add into a test that invokes CreatePool.

@mulkieran
Add support for Manager0
48d98cb 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Use Manager0
89eeb31 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the issue_stratis-cli_1033 branch from 67fb6bf to 513ce91 Compare December 4, 2023 18:29
@mulkieran
Sort out some tests
044e083 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the issue_stratis-cli_1033 branch from 513ce91 to 044e083 Compare December 4, 2023 18:44
@mulkieran
Copy link
Member Author

mulkieran commented Dec 4, 2023

This is not the correct way to do this. It should really be possible to make dynamic self-generating classes, and that would require working with dbus-python-client-gen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mulkieran mulkieran

Labels

None yet

Projects

tracking
Status: changelogs

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mulkieran