Skip to content

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Dec 9, 2025

Signed-off-by: mulhern <amulhern@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Walkthrough

The minimum Rust toolchain requirement in Cargo.toml is updated from version 1.77.0 to 1.82.0. This change modifies only the rust-version field under the [package] section, with no impact on dependencies or control flow.

Changes

Cohort / File(s) Summary
Rust version bump
Cargo.toml
Updated [package] rust-version from "1.77.0" to "1.82.0"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 Rust versions hop and climb,
From 1.77 to 1.82's time,
Toolchain grows, features bloom,
In Cargo's ancient tomb,
One line changed, the build runs true! 🦀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and directly describes the main change: updating the minimum supported Rust version from 1.77.0 to 1.82.0 in Cargo.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4c1be2 and a0a0d30.

📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: Check (aarch64-linux-android)
  • GitHub Check: Check (aarch64-unknown-linux-musl)
🔇 Additional comments (1)
Cargo.toml (1)

6-6: Verify Rust 1.82.0 validity and MSRV compliance.

The rust-version bump from 1.77.0 to 1.82.0 appears straightforward. However, before merging, confirm that:

  1. Rust 1.82.0 is a valid, stable release
  2. The codebase compiles and tests pass with this MSRV
  3. The motivation for the version bump (referenced in issue #832) is justified by required language features, compiler fixes, or dependency constraints
Is Rust 1.82.0 a valid stable release?

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran mulkieran added this to the 0.5.4 milestone Dec 9, 2025
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-loopdev-3-74-copr_pull
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran self-assigned this Dec 9, 2025
@mulkieran mulkieran merged commit 5cba75e into stratis-storage:master Dec 9, 2025
15 checks passed
@mulkieran mulkieran deleted the rust-version-1.82.0 branch December 9, 2025 01:34
@mulkieran mulkieran moved this from Done to Done(1) in 2025December Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done(1)

Development

Successfully merging this pull request may close these issues.

1 participant