Skip to content

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Nov 3, 2025

@mulkieran mulkieran self-assigned this Nov 3, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Walkthrough

Two GitHub Actions workflow files update their Rust toolchain version from 1.90.0 to 1.91.0. These are routine dependency version updates with no changes to workflow logic or configuration structure.

Changes

Cohort / File(s) Summary
Workflow Rust toolchain version bump
.github/workflows/ci.yml, .github/workflows/nightly.yml
Updated Rust toolchain from 1.90.0 to 1.91.0 in CI and nightly workflow configurations

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

These changes consist of simple version string updates in configuration files with no logic modifications or structural changes.

Possibly related issues

Possibly related PRs

Poem

🐰 A hop, a skip, the toolchain's updated
From ninety to ninety-one, coordinated
The workflows now hum with the latest release
Rust grows stronger, giving coders ease ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "github actions: Update recommended Rust to 1.91.0" directly and accurately describes the main change in the changeset. The modifications across both workflow files (ci.yml and nightly.yml) consistently update the Rust toolchain version from 1.90.0 to 1.91.0. The title is concise, specific, and uses clear language without vague terms or noise, making it easy for reviewers scanning the repository history to understand the purpose of this change.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22a7608 and fb7b011.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml (1 hunks)
  • .github/workflows/nightly.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: Check (x86_64-unknown-linux-gnu)
  • GitHub Check: Check (aarch64-unknown-linux-gnu)
  • GitHub Check: Check (aarch64-linux-android)
  • GitHub Check: Lints
🔇 Additional comments (3)
.github/workflows/ci.yml (1)

93-93: Rust toolchain version update looks good.

The version bump to 1.91.0 is clean and consistent with the PR objective. The inline comment clearly identifies this as the current development toolchain.

Please verify that Rust 1.91.0 is a stable, valid release and confirm there are no known breaking changes or compatibility issues that may affect the build or test workflows.

.github/workflows/nightly.yml (2)

34-34: Rust toolchain version update in nightly checks is consistent.

The version bump to 1.91.0 in the checks-with-ci-repo job aligns with the corresponding update in ci.yml and maintains consistency across workflows.


59-59: Rust toolchain version update for semver checks is consistent.

The version bump to 1.91.0 for the cargo-semver-checks-action ensures that semantic version checks run against the current development toolchain, keeping it in sync with the rest of the workflow updates.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: mulhern <amulhern@redhat.com>
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-loopdev-3-73-copr_pull
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran closed this Nov 3, 2025
@mulkieran mulkieran deleted the rust-1.91.0 branch November 3, 2025 02:27
@mulkieran mulkieran restored the rust-1.91.0 branch November 3, 2025 02:28
@mulkieran mulkieran reopened this Nov 3, 2025
@mulkieran mulkieran merged commit c4c1be2 into stratis-storage:master Nov 3, 2025
20 of 24 checks passed
@mulkieran mulkieran deleted the rust-1.91.0 branch November 3, 2025 02:29
@mulkieran mulkieran moved this from Done to Done(3) in 2025October Nov 4, 2025
@mulkieran mulkieran moved this from Done(3) to Done(4) in 2025October Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(4)

Development

Successfully merging this pull request may close these issues.

1 participant