Allow passing None as FEC and hash device when formatting as VERITY #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughMade Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)src/format.rs (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (38)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jonas2515
force-pushed
the
allow-passing-none
branch
from
8d45f1b to
e6768d0
Compare
jonas2515
changed the title
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
jonas2515
added a commit
to jonas2515/sysupdate-delta-updater-scripts
that referenced
this pull request
Dec 12, 2025
Add a small prototype to test passing FDs via varlink and opening them on the varlink server side. The varlink server then uses libcryptsetup-rs to create the dm-verity data for a given disk image that is passed in via varlink. Currently, a patched libcryptsetup-rs (with stratis-storage/libcryptsetup-rs#461 applied) is necessary for the dm-verity part to work. This is also useful to test the varlink server in a locked-down environment, as that's what we'll be working with as an actual sysupdate pull backend later. For a systemd-run command to lock down the server, see test_pull_server.rs.
jbaublitz
approved these changes
Dec 12, 2025
Member
jbaublitz
left a comment
jbaublitz
left a comment
There was a problem hiding this comment.
This looks good to me! Please rebase and I'll merge.
Make the fec_device and the hash_device fields in the CryptParamsVerity struct an Option<>, so that it's possible to pass NULL in the C crypt_params_verity struct. For fec_device, passing NULL to libcryptsetup indicates that no FEC device should be created. Because currently this is impossible, an FEC device must be created when using libcryptsetup-rs. The hash_device option is not used by libcryptsetup when formatting a verity partition, so allow passing NULL there as well.
jonas2515
force-pushed
the
allow-passing-none
branch
from
e6768d0 to
bba08ad
Compare
Member
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the fec_device and the hash_device fields in the CryptParamsVerity struct an Option<>, so that it's possible to pass NULL in the C crypt_params_verity struct.
For fec_device, passing NULL to libcryptsetup indicates that no FEC device should be created. Because currently this is impossible, an FEC device must be created when using libcryptsetup-rs.
The hash_device option is not used by libcryptsetup when formatting a verity partition, so allow passing NULL there as well.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.