Skip to content

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Dec 9, 2025

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran self-assigned this Dec 9, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Walkthrough

The minimum supported Rust toolchain version is bumped from 1.77.0 to 1.82.0 across the project's CI workflow and manifest files. Changes apply to the GitHub Actions workflow, root Cargo.toml, and the libcryptsetup-rs-sys crate manifest.

Changes

Cohort / File(s) Summary
Rust toolchain version bump
.github/workflows/main.yml, Cargo.toml, libcryptsetup-rs-sys/Cargo.toml
Updated minimum supported Rust version from 1.77.0 to 1.82.0 in CI jobs and manifests

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • #456: Modifies project Rust toolchain version in CI and manifest files
  • #444: Directly related toolchain version bump in the same files
  • #448: Continues bumping minimum Rust toolchain in Cargo.toml

Suggested reviewers

  • jbaublitz

Poem

🐰 A rusty version dance so bright,
From 77 to 82's new height,
Three files aligned, the toolchain's here,
Hopping forward without fear! 🦀✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the main change: updating the minimum supported Rust version from 1.77.0 to 1.82.0 across all configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 710cfc1 and ea6a410.

📒 Files selected for processing (3)
  • .github/workflows/main.yml (2 hunks)
  • Cargo.toml (1 hunks)
  • libcryptsetup-rs-sys/Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (36)
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: fedora (make -f Makefile test, cryptsetup-devel keyutils-libs-devel, 34)
  • GitHub Check: fedora (make -f Makefile build-examples, cryptsetup-devel, 38)
  • GitHub Check: fedora (make -f Makefile docs-ci, cryptsetup-devel, 38)
  • GitHub Check: fedora (make -f Makefile release, cryptsetup-devel, 38)
  • GitHub Check: fedora (make -f Makefile test-mutex, cryptsetup-devel keyutils-libs-devel, 38)
  • GitHub Check: fedora (make -f Makefile test-mutex-guard, cryptsetup-devel keyutils-libs-devel, 34)
  • GitHub Check: fedora (make -f Makefile docs-ci, cryptsetup-devel, 34)
  • GitHub Check: fedora (make -f Makefile release, cryptsetup-devel, 34)
  • GitHub Check: fedora (make -f Makefile build, cryptsetup-devel, 38)
  • GitHub Check: fedora (make -f Makefile build-examples, cryptsetup-devel, 34)
  • GitHub Check: fedora (make -f Makefile test-loopback, cryptsetup-devel keyutils-libs-devel, 34)
  • GitHub Check: fedora (make -f Makefile build, cryptsetup-devel, 34)
  • GitHub Check: fedora (make -f Makefile release, cryptsetup-devel, 33)
  • GitHub Check: fedora (make -f Makefile test-loopback, cryptsetup-devel keyutils-libs-devel, 33)
  • GitHub Check: fedora (make -f Makefile test-mutex, cryptsetup-devel keyutils-libs-devel, 33)
  • GitHub Check: fedora (make -f Makefile build-examples, cryptsetup-devel, 33)
  • GitHub Check: fedora (make -f Makefile test, cryptsetup-devel keyutils-libs-devel, 33)
  • GitHub Check: fedora (make -f Makefile build, cryptsetup-devel, 33)
  • GitHub Check: stable (make -f Makefile release, libcryptsetup-dev)
  • GitHub Check: typos
🔇 Additional comments (4)
Cargo.toml (1)

6-6: MSRV bump is valid and properly documented.

Rust 1.82.0 was released on October 17, 2024, and the version string format is correct. The change is consistent with corresponding updates in the sys crate and CI workflow.

libcryptsetup-rs-sys/Cargo.toml (1)

6-6: MSRV bump is consistent across crates.

The sys crate's minimum version matches the root crate, maintaining consistent MSRV policy across the project.

.github/workflows/main.yml (2)

118-120: CI MSRV job correctly updated.

The lowest_supported job now tests against Rust 1.82.0, aligned with the manifest changes. The job ensures the project compiles and tests successfully at the declared minimum version.


147-150: Fedora CI job MSRV updated consistently.

The fedora job now tests against Rust 1.82.0 across multiple Fedora container versions, maintaining the consistent MSRV policy and ensuring platform-specific compatibility at the minimum supported version.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran mulkieran moved this to In Review in 2025December Dec 9, 2025
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-libcryptsetup-rs-457
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran added this to the 0.14.1 milestone Dec 9, 2025
@mulkieran mulkieran merged commit 60be64c into stratis-storage:master Dec 9, 2025
45 checks passed
@mulkieran mulkieran deleted the rust-version-1.82.0 branch December 9, 2025 01:29
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025December Dec 9, 2025
@mulkieran mulkieran moved this from Done to Done(1) in 2025December Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(1)

Development

Successfully merging this pull request may close these issues.

1 participant