Skip to content

Trim the end of the target type string #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Mar 5, 2019
Merged

Trim the end of the target type string #435

mergify merged 1 commit into from
Mar 5, 2019

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Mar 5, 2019

To be on the safe side. Also, it looks tidier because it matches the code
block following.

Signed-off-by: mulhern amulhern@redhat.com

@mulkieran
Trim the end of the target type string
157e993 
To be on the safe side. Also, it looks tidier because it matches the code
block following.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran self-assigned this Mar 5, 2019
@mulkieran mulkieran requested review from tasleson and trgill March 5, 2019 15:18
@mulkieran
Copy link
Member Author

mulkieran commented Mar 5, 2019

This is cherry-picked from #430 , because it is really more or less orthogonal. I think there are a bunch of other things that should be done to improve this method, but these things apply to a lot of other methods, so I filed a few issues instead: #434 , #433 .

@mergify mergify bot merged commit c31cccd into stratis-storage:master Mar 5, 2019
@mulkieran mulkieran deleted the master-parse-table branch March 5, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tasleson tasleson tasleson approved these changes

@trgill trgill trgill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mulkieran mulkieran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mulkieran @tasleson @trgill