Fix bug: ADT constructors do not change Map to Array when using useArrayTheory option.#1145
Open
thanhnguyen-aws wants to merge 3 commits into
Open
Fix bug: ADT constructors do not change Map to Array when using useArrayTheory option.#1145thanhnguyen-aws wants to merge 3 commits into
Map to Array when using useArrayTheory option.#1145thanhnguyen-aws wants to merge 3 commits into
Conversation
Contributor
Author
|
@keyboardDrummer-bot Please add more PR description and add a test. |
Collaborator
|
The PR description and tests are already in place:
Let me know if you'd like any changes to the description or additional test coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Bug: When
useArrayTheoryis enabled, the SMT encoder correctly convertsMaptypes toArrayin variable declarations and function signatures, but it did not perform this conversion for fields inside ADT (algebraic data type) constructor declarations. This caused a type mismatch: a datatype field would be declared with typeMapwhile the rest of the encoding usedArray.Fix: Thread the
useArrayTheoryflag through the datatype emission pipeline:lMonoTyToTermTypenow acceptsuseArrayTheoryand convertsMaptoArraywhen enabled.datatypeConstructorsToSMTpasses the flag tolMonoTyToTermType.SMT.Context.emitDatatypesaccepts and forwards the flag.encodeCoreinVerifier.leanpassesoptions.useArrayTheorytoemitDatatypes.Test: Added a unit test in
SMTEncoderDatatypeTest.leanthat verifies a datatype with aMap-typed field emits(Array Int Int)whenuseArrayTheory=trueand(Map Int Int)whenuseArrayTheory=false.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.