fix(init): remove rc versions, @types/react 18, no run#120
fix(init): remove rc versions, @types/react 18, no run#120unrevised6419 wants to merge 1 commit intostrapi:mainfrom
Conversation
|
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
There was a problem hiding this comment.
Note: Husky deprecated this syntax in 9, will be removed in 10
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
There was a problem hiding this comment.
Note: Husky deprecated this syntax in 9, will be removed in 10
|
| react: '^17.0.0 || ^18.0.0', | ||
| 'react-dom': '^17.0.0 || ^18.0.0', | ||
| react: '^18.0.0', | ||
| 'react-dom': '^18.0.0', |
There was a problem hiding this comment.
Note: In the end it will still resolve to the biggest from them. Also creating a new plugin with v17 kind of does not make sense.
| '@types/react': '*', | ||
| '@types/react-dom': '*', | ||
| '@types/react': '^18.0.0', | ||
| '@types/react-dom': '^18.0.0', |
There was a problem hiding this comment.
Note: Without this the version resolves to v19
| pkgJson.scripts = { | ||
| ...pkgJson.scripts, | ||
| 'test:ts:front': 'run -T tsc -p admin/tsconfig.json', | ||
| 'test:ts:front': 'tsc -p admin/tsconfig.json', |
There was a problem hiding this comment.
Note: There is no such binary run
| pkgJson.scripts = { | ||
| ...pkgJson.scripts, | ||
| 'test:ts:back': 'run -T tsc -p server/tsconfig.json', | ||
| 'test:ts:back': 'tsc -p server/tsconfig.json', |
There was a problem hiding this comment.
Note: There is no such binary run
| */ | ||
|
|
||
| // TODO: remove these when release versions are available | ||
| export const USE_RC_VERSIONS: string[] = ['@strapi/design-system', '@strapi/icons']; |
There was a problem hiding this comment.
Note: As of this writing the versions are 2.2.0
unrevised6419
changed the title
1 participant
Closes #119