Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
pr: updated content
|
@boazpoolman do you think this is ok from a community perspective? is there something else worth including? |
|
Thank you, @jhoward1994! |
|
Thanks @pwizla yep feel free to do that 🙏🏻 |
These notes are automatically generated.
There was a problem hiding this comment.
Thank you again, Jamie.
The PR is approved from a technical writing perspective 🤓
I tentatively added the (docs-related) 6.15.0 milestone, planned for Wed., Jan. 28, and also added the flag: merge pending release label, which will prevent merging, to ensure we do not release the docs too early. Feel free to ping me if I need to postpone it to another release 😊
boazpoolman
left a comment
boazpoolman
left a comment
There was a problem hiding this comment.
Hi @innerdvations & @jhoward1994,
I haven't looked too much at the code of the pack-up removal PR, but I did pull it down and tried it out based on this updated documentation. I'll leave my feedback here if that's OK.
| * You can delete any `packup.config.ts` file from your plugin (it's no longer used). | ||
| * Build configuration is now derived automatically from `package.json#exports`. | ||
| * If you need sourcemaps, add `--sourcemap` to your build command (they now default to off). | ||
|
|
There was a problem hiding this comment.
A user might use the pack-up CLI directly, instead of the strapi-plugin abstraction. We should add another bullet explaining that these commands need to be replaced.
| | `--sourcemap` | - | Produce sourcemaps | false | | ||
|
|
||
| :::note | ||
| As of v6, the build configuration is automatically derived from your `package.json` exports field. No configuration file (such as `vite.config.ts` or `rollup.config.ts`) is needed. |
There was a problem hiding this comment.
I'm a little confused about this part. How exactly do I define build configuration in the package.json?
I'll take the REST cache plugin again as an example. The package.json#exports defines a custom /types export. In version 5 of the plugin SDK I had to acompany this with a customized packup.config.ts to actually build the file before being able to export it.
If I just remove the packup.config.ts file with the updated plugin SDK the file isn't automatically built based just on the package.json#exports. Do we need a custom vite.config.ts or rollup.config.ts in this case?
There was a problem hiding this comment.
I see what you mean. Does this commit address that use case ? strapi/sdk-plugin@e1dee66 (#103)
4 participants
Description
Documentation in support of a new major version release for the sdk plugin
(see linked PR)
Related issue(s)/PR(s)
Following release of:
strapi/sdk-plugin#103