-
Notifications
You must be signed in to change notification settings - Fork 203
Fix: missing localizations in middleware populate
#98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@PaulBratslavsky while doing #90 , I figured out that the I also updated Strapi to the latest version as said in the todos and ran some shai-hulud 2.0 scans against the package.json and the repo, which threw no errors. I saw some potential to simplifie and cleanup some code as well, which I also included here. Please let me know what you think about it 👍 |
localizations in middleware populate
alex-strapi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for removing patch-package too!
What does it do?
Fixes the missing
localizationskey in middleware populate. Also added some cleanup.Why is it needed?
Because of this the locale switcher was not showing up in the main header section.
How to test it?
When going on the page, the locale switcher should show the available locales from Strapi.
Some additional things to check:
strapi/packages.json.strapi/scripts/prefillLoginFields.jsworks.strapi/datafolder and update thestrapi/packages.jsonseed command if necessary.Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request.