fix: set use_native_token_count default to false#2284
Open
opieter-aws wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Assessment: Approve Clean, well-scoped fix that correctly changes Review Details
Nice fix addressing a real user-reported latency regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the default value of
use_native_token_countfromTruetoFalseacross all model providers (Bedrock, Anthropic, Gemini, LlamaCpp, OpenAI Responses).Since v1.38.0, the event loop calls
count_tokens()before every model invocation. Whenuse_native_token_count=True(the previous default), this makes an additional network round-trip that processes the full message payload -- including images -- before the actual inference call. For multimodal/image workloads, this adds 25-50% per-invocation latency with no indication of why.This change makes native token counting opt-in rather than opt-out, so users must explicitly set
use_native_token_count=Trueto enable the native API calls.Related Issues
Fixes #2277
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.