ci: update openai requirement from <1.110.0,>=1.68.0 to >=1.68.0,<2.22.0#1700
Open
dependabot[bot] wants to merge 1 commit intomainfrom
Open
ci: update openai requirement from <1.110.0,>=1.68.0 to >=1.68.0,<2.22.0#1700dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Updates the requirements on [openai](https://github.com/openai/openai-python) to permit the latest version. - [Release notes](https://github.com/openai/openai-python/releases) - [Changelog](https://github.com/openai/openai-python/blob/main/CHANGELOG.md) - [Commits](openai/openai-python@v1.68.0...v2.21.0) --- updated-dependencies: - dependency-name: openai dependency-version: 2.21.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| mistral = ["mistralai>=1.8.2"] | ||
| ollama = ["ollama>=0.4.8,<1.0.0"] | ||
| openai = ["openai>=1.68.0,<2.0.0"] | ||
| openai = ["openai>=1.68.0,<3.0.0"] |
There was a problem hiding this comment.
Issue: The upper bound <3.0.0 is very permissive and allows all openai v2.x versions. OpenAI SDK v2.0.0 introduced breaking changes (e.g., ResponseFunctionToolCallOutputItem.output return type changed).
Suggestion: Consider either:
- A more conservative upper bound like
<2.22.0(matching the PR title) until compatibility is fully verified - Explicitly documenting that v2.x compatibility has been tested
Has the SDK been tested against openai v2.x to verify there are no runtime issues?
|
Assessment: Comment This Dependabot PR updates the openai dependency constraint, but there are a few concerns to address. Review Summary
The SDK's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on openai to permit the latest version.
Release notes
Sourced from openai's releases.
Changelog
Sourced from openai's changelog.
... (truncated)
Commits
3e0c05brelease: 2.21.0e93f6cffix(webhooks): preserve method visibility for compatibility checks3ddbb7efeat(api): container network_policy and skills156d518docs: splitapi.mdby standalone resources72e1e15fix(structured outputs): resolve memory leak in parse methods (#2860)d81ee8fcodegen metadata01c9eeecodegen metadata957dadfchore(internal): fix lint error on Python 3.147b26bd3docs: update commentf2d096frelease: 2.20.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)