-
Notifications
You must be signed in to change notification settings - Fork 145
ci: trigger preview deployments #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| - name: Trigger documentation deployment | ||
| env: | ||
| # PAT token with 'repo' scope needed to trigger repository_dispatch events in other repositories | ||
| GH_TOKEN: ${{ secrets.PAT_GITHUB_TOKEN_STRANDS || secrets.PAT_GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we label this something specific to the use of the token?
E.g:
secrets.WEBSITE_PAT_TOKEN
or something? We're starting to gather a lot of tokens, esp if we put agents in various repos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used these because it was already being used in https://github.com/strands-agents/strandsagents.com/blob/3542359b1f1f1434c505423b668bf7ce8386ab34/.github/workflows/docs-preview.yml#L53 and I wanted to avoid creating more PAT names
Would you prefer a special secret name for the pat? Or I suppose a scoped down pat for just this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah honestly, I'd prefer a scoped down PAT
Description
This PR will enable easier reviews by publishing static preview builds. This is being done by triggering a workflow on a private repository.
The PR on the internal repository is https://github.com/strands-agents/strandsagents.com/pull/34
Type of Change
Checklist
mkdocs serveBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.