Skip to content

Conversation

@dbschmigelski
Copy link
Member

@dbschmigelski dbschmigelski commented Dec 22, 2025

Description

This PR will enable easier reviews by publishing static preview builds. This is being done by triggering a workflow on a private repository.

The PR on the internal repository is https://github.com/strands-agents/strandsagents.com/pull/34

Type of Change

  • Preview page generation

Checklist

  • I have read the CONTRIBUTING document
  • [n/a] My changes follow the project's documentation style
  • [n/a] I have tested the documentation locally using mkdocs serve
  • [n/a] Links in the documentation are valid and working
  • [n/a] Images/diagrams are properly sized and formatted
  • [n/a] All new and existing tests pass

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dbschmigelski dbschmigelski marked this pull request as ready for review December 22, 2025 21:01
zastrowm
zastrowm previously approved these changes Dec 23, 2025
- name: Trigger documentation deployment
env:
# PAT token with 'repo' scope needed to trigger repository_dispatch events in other repositories
GH_TOKEN: ${{ secrets.PAT_GITHUB_TOKEN_STRANDS || secrets.PAT_GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we label this something specific to the use of the token?

E.g:

secrets.WEBSITE_PAT_TOKEN

or something? We're starting to gather a lot of tokens, esp if we put agents in various repos

Copy link
Member Author

@dbschmigelski dbschmigelski Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used these because it was already being used in https://github.com/strands-agents/strandsagents.com/blob/3542359b1f1f1434c505423b668bf7ce8386ab34/.github/workflows/docs-preview.yml#L53 and I wanted to avoid creating more PAT names

Would you prefer a special secret name for the pat? Or I suppose a scoped down pat for just this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah honestly, I'd prefer a scoped down PAT

yonib05
yonib05 previously approved these changes Dec 23, 2025
@dbschmigelski dbschmigelski dismissed stale reviews from yonib05 and zastrowm via 88b4d77 December 23, 2025 18:52
zastrowm
zastrowm previously approved these changes Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants