Skip to content

Conversation

@Spablob
Copy link
Collaborator

@Spablob Spablob commented Nov 7, 2025

Description

Safe migration scripts plus a script that adds a new admin role to the safe governance that will control the selected selectors. Changes using these selectors will be cancellable by the security council.

@Spablob Spablob changed the title Add new admin role Add safe migration scripts and new admin role Nov 7, 2025
@Spablob Spablob changed the title Add safe migration scripts and new admin role Add new admin role Dec 5, 2025
@Ramarti
Copy link

Ramarti commented Dec 9, 2025

-[x] Correct multisig addresses
-[x] Correct sc addresses
-[x] All relevant methods
-[x] Granted the roles

@Spablob
Copy link
Collaborator Author

Spablob commented Dec 9, 2025

  • All relevant methods setTargetRole Missing: -- IPAssetRegistry.upgradeIPAccountImpl
    This already belongs to role id = 1 = UPGRADER_ROLE
image

@Spablob
Copy link
Collaborator Author

Spablob commented Dec 16, 2025

@Spablob fixed formatting and typo, what I meant is IPAssetRegistry.setTargetRole is missing as target role. You are right about the role assignment, checking that box.

I believe there are only 3 restricted functions in IPAssetRegistry contract - 2 of which belong to the upgrader role - so there is only 1 function for the new role. So it should be ok as-is.

@Spablob Spablob marked this pull request as ready for review December 17, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants