Skip to content

Conversation

@P0lip
Copy link
Contributor

@P0lip P0lip commented Jan 13, 2022

2 reasons for doing so:

  • enabling esModuleInterop in feat: dual packaging #168 without changing too much of the code
  • we just don't need that dependency at all

@P0lip P0lip changed the base branch from master to beta March 23, 2022 19:27
@P0lip P0lip marked this pull request as ready for review March 23, 2022 19:27
@P0lip P0lip requested review from lott-ai and marbemac as code owners March 23, 2022 19:27
@P0lip P0lip self-assigned this Mar 23, 2022
@P0lip P0lip added the enhancement New feature or request label Mar 23, 2022
@P0lip P0lip requested a review from a team March 23, 2022 19:27
Copy link
Contributor

@lott-ai lott-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming it doesn't break anything downstream (which I assume it does not)

@P0lip
Copy link
Contributor Author

P0lip commented Mar 23, 2022

It shouldn't, yeah.

@P0lip P0lip merged commit f615551 into beta Mar 23, 2022
@P0lip P0lip deleted the feat/uri-js branch March 23, 2022 20:24
P0lip added a commit that referenced this pull request Mar 24, 2022
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 5.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

P0lip added a commit that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request released on @beta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants