Hard check the ID at Init #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cparata would you be ok to fix style for me? Not sure how it is set up and I dont want to shotgun debug the CICD linter :) . |
Contributor
|
I applied the patch on the main branch. We can close this PR. |
Contributor
Author
|
Perfect, thank you so much! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some I2C implementations (for example, the arduino core I am using in a project), I2C communication failing to acknowledge / work can fail silently. This, combined with how the library works, means that using this library with some arduino cores may fail silently and just provide all 0s.
To mitigate this, this PR now explicitly checks the ISM330DHCX_ID during
begin; this way, even if the communication fails silently and all 0s are returned, we will catch it and return an error status.Validation
Using this PR, I now get failure if I use the wrong port / address in my arduino core, which otherwise was failing silently.
@cparata this should fix what is discussed in #13 (comment) .
I am not a professional embedded programmer - if you want to see changes, please either be very clear what you want me to change, or feel free to edit this PR :) .