-
Notifications
You must be signed in to change notification settings - Fork 49
Layout forest dumping API #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sean-parent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A unit test for these changes is required.
|
|
||
| auto top = eve.add_placeable(adobe::eve_t::iterator(), adobe::layout_attributes_t(), false, placeable_row, false); | ||
|
|
||
| eve.print_debug(result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check that the string matches something known.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this, too, but the name of the type is implementation dependent, so will change from compiler to compiler. Do you have a suggestion on how that could be mitigated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this workaround will suffice?
sean-parent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds
eve_t::dump()which outputs theview_proxy_tforest tostderr. The format looks like an eve2 layout description, except the name of the widget is the underlyingplaceableinstance, and the parameters are taken directly from theview_proxy_t's attributes. Example: