Add GitHub workflow and Update dependency#10
Add GitHub workflow and Update dependency#10alikemalocalan wants to merge 9 commits intostitchdata:masterfrom
Conversation
|
@psantacl @cmerrick @mdelaurentis Would it be possible for you to review this request? Due to severe vulnerabilities a release with updated dependencies would be very desirable. Thank You! @alikemalocalan fyi |
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s build/release setup (Maven plugins, Java level, dependencies) and adds GitHub automation, while also updating the client implementation to use Java 11’s java.net.http.HttpClient and Jakarta JSON.
Changes:
- Update
pom.xmlfor Java 11, newer Maven release/publish plugins, and dependency refresh (including removing Apache HttpClient in favor of JDK HTTP client). - Add GitHub Actions CI workflows and Dependabot configuration for Maven dependencies.
- Replace previously “example” main classes with JUnit tests that exercise the same flows; add a test asserting HTTP/1.1 usage.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/com/stitchdata/client/StitchClient.java |
Switch HTTP transport to java.net.http.HttpClient, update JSON parsing, add helper for JSON content-type detection. |
src/main/java/com/stitchdata/client/StitchResponse.java |
Migrate JSON type to jakarta.json.JsonObject. |
src/main/java/com/stitchdata/client/StitchClientBuilder.java |
Formatting/type tweaks around Transit write handlers and builder build() formatting. |
src/main/java/com/stitchdata/client/Buffer.java |
Import cleanup and formatting-only changes. |
src/test/java/com/stitchdata/client/StitchClientTest.java |
Import cleanup/formatting; add test asserting client uses HTTP/1.1. |
src/test/java/com/stitchdata/client/BufferTest.java |
Import cleanup/formatting. |
src/test/java/com/stitchdata/client/SimpleExampleTest.java |
New test replacing the removed “simple example” main program flow. |
src/test/java/com/stitchdata/client/CallbackExampleTest.java |
New test replacing the removed “callback example” main program flow. |
src/main/java/com/stitchdata/client/examples/SimpleExample.java |
Removed example main program (superseded by tests). |
src/main/java/com/stitchdata/client/examples/CallbackExample.java |
Removed example main program (superseded by tests). |
pom.xml |
Update compiler level to 11; update Maven plugins; refresh dependencies (Transit, Jakarta JSON, JUnit), remove Apache HttpClient dependency. |
.github/workflows/maven.yml |
New Maven build workflow (currently restricted to master). |
.github/workflows/maven-unit-tests.yml |
New unit test workflow for Java 11/17 (currently push only). |
.github/dependabot.yml |
New Dependabot configuration for Maven. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Would it be possible for you to review this request by yourself? Because Copilot reviewer find small unnecessary typos every time. Thank You! |
Description of change
This PR includes Maven project configuration improvements, a migration to Java's built-in HTTP client, and a packaging surface change for example classes.
What changed
java.net.http.HttpClientfor all network calls to Stitch.pom.xml(source, javadoc, GPG signing, Nexus staging, and release flow).com.stitchdata.client.examples.*classes fromsrc/main.src/test) so they are no longer part of the published runtime artifact.Why
Runtime behavior changes
This change modifies runtime HTTP behavior including:
Published artifact changes
com.stitchdata.client.examples.*classes are no longer shipped in the main artifact.QA steps
Manual QA steps:
com.stitchdata.client.examples.*is absent from the published runtime JAR and examples remain available in test sources/docs.Risks
com.stitchdata.client.examples.*from the published artifact will fail to compile until migrated.Rollback steps