Conversation
Submodule advanced 34b24b25 -> ee98fba9. Upstream removed the Correlations, Utilities/Register, and DistributedSemaphores subsystems, dropped the maxWait parameter from Workflow.Message, and reworked the suspend/interrupt lifecycle. Adapt dependent code accordingly: - Flow.cs: drop Utilities proxy and maxWait parameter from Message overloads - Flows.cs: remove RouteMessage from IBaseFlows/BaseFlows and overrides - Delete CorrelationIdFlowTests (relied on removed RegisterCorrelation/RouteMessage) - Delete unused PostmanExtensions (reflected over removed Postman.RouteMessage) - Samples: replace Message<T>(maxWait:) with waitFor:, drop Synchronization.AcquireLock calls Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
TransferFlow1 demonstrated the distributed-lock variant of the bank transfer; with DistributedSemaphores removed upstream, its body became identical to TransferFlow0. Drop the duplicate so the presentation does not imply two distinct solutions exist. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Will be re-added later once a fitting illustration of the post-lock-removal API has been worked out. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleipnir.ResilientFunctionssubmodule34b24b25→ee98fba9(~40 commits, including breaking API changes).Cleipnir/,Cleipnir.Tests/, andSamples/to the new surface.Upstream removals handled
Workflow.RegisterCorrelation,Postman.RouteMessage,*Registration.RouteMessage,ICorrelationStore.Utilitiesrecord andIRegister.Workflow.Synchronization.AcquireLock,DistributedSemaphore.Lock,ISemaphoreStore.maxWaitparameter removed across all overloads.Code changes
Cleipnir/Flow.cs: dropUtilitiesproxy property; rewrite the sixMessage<T>(...)overloads withoutmaxWait.Cleipnir/Flows.cs: removeRouteMessage<T>fromIBaseFlows/BaseFlows<TFlow>and the three concrete overrides.Cleipnir.Tests/Flows/CorrelationIdFlowTests.cs: deleted — entire test exercises removed APIs.Samples/.../MessageDriven/Other/PostmanExtensions.cs: deleted — unused helper that reflected over removedPostman.RouteMessage.SignupFlow.cs,NewsletterParentFlow.cs:Message<T>(maxWait:)→Message<T>(waitFor:).BankTransfersamples: removedWorkflow.Synchronization.AcquireLock(...)/DistributedSemaphore.Lock(subsystem deleted upstream).Test plan
dotnet build Cleipnir.NET.sln— clean (0 warnings, 0 errors).dotnet test Cleipnir.Tests— 25/25 passed.Cleipnir.Tests.AspNetandServiceBuses/*.Tests— compile, but require docker-compose-managed SQL Server / MariaDB / Postgres / Kafka / RabbitMQ; not run locally.🤖 Generated with Claude Code