Merged
Conversation
The attribute was only used as a marker on sample flow classes and had no associated generator or runtime behavior. Drop the attribute type and strip its usages from all sample files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleipnir/GenerateFlowsAttribute.cs— the attribute had no generator or runtime behavior backing it[GenerateFlows]marker from all 24 sample files that referenced it (including the commented-out usage inSamples/Cleipnir.Sample.Presentation.AspNet/Flows/Rpc/OrderFlow.cs)Test plan
dotnet build Cleipnir.NET.sln— note: there are 2 pre-existing build errors onmainrelated to aCompletion(timeout: ...)overload inCleipnir.Kafka.TestsandCleipnir.Tests; both reproduce without this PR and are unrelated to the attribute removal🤖 Generated with Claude Code