Alicepoolfix#43
Open
Jo-stfc wants to merge 2 commits intov5.8.4patchedfrom
Open
Conversation
alex-rg
reviewed
Mar 19, 2026
alex-rg
reviewed
Mar 19, 2026
| return 1; | ||
| } | ||
| // EC correction factor for pool reporting | ||
| if (!strncmp(var, "ceph.ECcorrectionFactor", 8)) { // size in bytes |
There was a problem hiding this comment.
For readability, it would be good to increase indentation for this block (+1 space for this if, so that it is aligned with the above code, and then +2 spaces for the body of this if).
alex-rg
reviewed
Mar 19, 2026
| return 1; | ||
| } | ||
| } | ||
| else{ |
There was a problem hiding this comment.
This else should be on the previous line?
alex-rg
reviewed
Mar 19, 2026
| return -EINVAL; | ||
| } | ||
|
|
||
alex-rg
reviewed
Mar 19, 2026
| return 1; | ||
| } | ||
| // EC correction factor for pool reporting | ||
| if (!strncmp(var, "ceph.ECcorrectionFactor", 8)) { // size in bytes |
There was a problem hiding this comment.
The last argument for strncmp should be 23 (length of the "ceph.ECcorrectionFactor" string)?
code review improvements
alex-rg
reviewed
Mar 30, 2026
| Eroute.Emsg("Config", "Invalid value for ceph.ECcorrectionFactor in config file; enter a value between 0 and 1", configfn, var); | ||
| return 1; | ||
| } | ||
| } else { |
There was a problem hiding this comment.
I think, it's better to add 2 spaces in the beginning of this line, as well as 3 lines below, so that the block matches indentation of the corresponding if.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add EC correction factor for pool space reporting