Net10 #45
Merged
Net10 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated all project files, build scripts, and CI workflow from .NET 8 to .NET 10 for Android, iOS, MacCatalyst, and Windows targets. Updated related paths and conditions in build and publish scripts. Fixed a typo in the README and removed the project history section.
Removed iOS and MacCatalyst from the TargetFrameworks list, restricting the project to build only for Android. Also removed a Windows-specific PropertyGroup related to Android SDK directory configuration.
Bump .NET version to 10.0.x in the GitHub Actions workflow and update the project to target net10.0-windows. Replace explicit MAUI workload installs with 'dotnet workload restore' and update Microsoft.Windows.Compatibility package to version 10.0.0.
There was a problem hiding this comment.
Pull request overview
This PR attempts to upgrade the LockPDFy project from .NET 8.0 to .NET 10.0 across all project files and build scripts. However, this PR contains a critical issue: .NET 10.0 does not exist yet (as of January 2025, the latest stable version is .NET 9.0).
Key changes attempted:
- Updated all target framework references from
net8.0tonet10.0across multiple platforms (Windows, Android, iOS, macOS) - Updated CI/CD workflow to use .NET 10.0.x SDK
- Fixed a spelling error in README.md ("Commont" → "Common")
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| publishAndroidApp.ps1 | Updated Android build script to target net10.0-android (invalid version) |
| README.md | Fixed spelling error and removed history section |
| LockPDFyWinforms/LockPDFyWinforms.csproj | Updated to net10.0-windows and Microsoft.Windows.Compatibility 10.0.0 (both invalid versions) |
| LockPDFyTests/LockPDFyTests.csproj | Updated test project to target net10.0 (invalid version) |
| LockPDFyMaui/LockPDFyMaui.csproj | Updated MAUI project to target net10.0 across all platforms and removed Android SDK configuration |
| .github/workflows/dotnet.yml | Updated CI/CD to use .NET 10.0.x SDK and updated workload installation approach (invalid version) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The GitHub Actions workflow for dotnet will no longer run on pull request events. This change may be intended to limit workflow runs to pushes and manual dispatches only.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.