541 drop fee stats agg#2419
Open
ttboogie wants to merge 3 commits into
Open
Conversation
Removes deprecated fee_stats_agg data dictionary page and updates the Horizon-like queries guide to reference daily_fee_stats_agg and ledger_fee_stats_agg as the current fee stats models. Refs stellar/hubble#541 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replaces the deprecation note with a single sentence describing the two replacement models, since fee_stats_agg is being removed. Refs stellar/hubble#541 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
hello how are you?
…On Fri, May 1, 2026, 3:34 PM Trevor Thayer ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#2419
Commit Summary
- d77fb39
<d77fb39>
drop fee_stats_agg references from analytics docs
- ca3689c
<ca3689c>
update fee stats query examples to point at new models
File Changes
(2 files <https://github.com/stellar/stellar-docs/pull/2419/files>)
- *M*
docs/data/analytics/hubble/analyst-guide/queries-for-horizon-like-data.mdx
<https://github.com/stellar/stellar-docs/pull/2419/files#diff-ee7c94a4fc04acbb52d978fd09a6100b9064d7e8668e9b2740eb15f8c57df0b5>
(8)
- *D*
docs/data/analytics/hubble/data-catalog/data-dictionary/gold/fee-stats-agg.mdx
<https://github.com/stellar/stellar-docs/pull/2419/files#diff-52da501a85a59be4834fa1d19a29b45c99e08a33479e6c065dd804026451a886>
(56)
Patch Links:
- https://github.com/stellar/stellar-docs/pull/2419.patch
- https://github.com/stellar/stellar-docs/pull/2419.diff
—
Reply to this email directly, view it on GitHub
<#2419>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5LQRFJZNRCZNSDQ7P2CG2D4YUQ6VAVCNFSM6AAAAACYN36ZWCVHI2DSMVQWIX3LMV43ASLTON2WKOZUGM3DMOJVGYYTKMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Preview is available here: |
6 tasks
CI rebuilds routes.txt and fails on diff. Removing the route for the deleted fee-stats-agg data dictionary page. Refs stellar/hubble#541 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Warning This change removes routes. The diff of routes is below. Please verify that these changes to the routes are intentional and that redirects are in place if needed. Redirects can be added to diff --git a/routes.txt b/routes.txt
index 0c02d4e5..b4c54887 100644
--- a/routes.txt
+++ b/routes.txt
@@ -225,7 +225,6 @@
/docs/data/analytics/hubble/data-catalog/data-dictionary/gold
/docs/data/analytics/hubble/data-catalog/data-dictionary/gold/asset-balances-daily-agg
/docs/data/analytics/hubble/data-catalog/data-dictionary/gold/daily-fee-stats-agg
-/docs/data/analytics/hubble/data-catalog/data-dictionary/gold/fee-stats-agg
/docs/data/analytics/hubble/data-catalog/data-dictionary/gold/hourly-fee-agg-account
/docs/data/analytics/hubble/data-catalog/data-dictionary/gold/hourly-soroban-fee-agg-contract
/docs/data/analytics/hubble/data-catalog/data-dictionary/gold/ledger-fee-stats-agg
|
|
Preview is available here: |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes documentation for the deprecated Hubble fee_stats_agg model and updates the Horizon-like query guide to reference the two replacement models (daily_fee_stats_agg and ledger_fee_stats_agg).
Changes:
- Removed the legacy
fee-stats-aggdata dictionary page. - Updated the Fee Stats section in the Horizon-like queries guide to reference
daily_fee_stats_aggandledger_fee_stats_agg. - Updated
routes.txtto reflect the removed route.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
routes.txt |
Drops the fee-stats-agg route entry to match the removed doc page. |
docs/data/analytics/hubble/data-catalog/data-dictionary/gold/fee-stats-agg.mdx |
Deleted the deprecated model’s data dictionary page. |
docs/data/analytics/hubble/analyst-guide/queries-for-horizon-like-data.mdx |
Replaces the deprecation note with guidance pointing to the two replacement models. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -225,7 +225,6 @@ | |||
| /docs/data/analytics/hubble/data-catalog/data-dictionary/gold | |||
| /docs/data/analytics/hubble/data-catalog/data-dictionary/gold/asset-balances-daily-agg | |||
| /docs/data/analytics/hubble/data-catalog/data-dictionary/gold/daily-fee-stats-agg | |||
Comment on lines
812
to
815
| [horizon/fee-stats](../../../apis/horizon/api-reference/aggregations/fee-stats/README.mdx) | ||
|
|
||
| Fee stats are used to predict what fee to set for a transaction before submitting it to the network. | ||
|
|
||
| :::note | ||
|
|
||
| The `fee_stats_agg` model has been deprecated and replaced by two new models: `ledger_fee_stats_agg` (ledger-grain) and `daily_fee_stats_agg` (daily-grain). The new models provide separate Classic and Soroban fee breakdowns, inclusion fee metrics, and surge pricing statistics. | ||
|
|
||
| ::: | ||
| Fee stats are used to predict what fee to set for a transaction before submitting it to the network. Two models are available: `ledger_fee_stats_agg` (ledger-grain) and `daily_fee_stats_agg` (daily-grain). Both provide separate Classic and Soroban fee breakdowns, inclusion fee metrics, and surge pricing statistics. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Chore should automatically handle translation.
amishas157
approved these changes
May 5, 2026
briwylde08
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes documentation for the deprecated
fee_stats_aggmodel.Refs stellar/hubble#541
What
docs/data/analytics/hubble/data-catalog/data-dictionary/gold/fee-stats-agg.mdx(the data dictionary page for the legacy model).docs/data/analytics/hubble/analyst-guide/queries-for-horizon-like-data.mdxto drop thefee_stats_aggdeprecation note and point readers directly at the two replacement models.Why
The
fee_stats_aggdbt model is being dropped (see stellar/stellar-dbt-public#239) in favor ofdaily_fee_stats_aggandledger_fee_stats_agg, which split Classic vs. Soroban transactions and add surge-pricing and inclusion-fee metrics. Both replacements already have data dictionary pages undergold/.