Fix Version Marker Pattern test examples to use proper contract context#2300
Closed
Copilot wants to merge 2 commits intomigrate-contract-storagefrom
Closed
Fix Version Marker Pattern test examples to use proper contract context#2300Copilot wants to merge 2 commits intomigrate-contract-storagefrom
Copilot wants to merge 2 commits intomigrate-contract-storagefrom
Conversation
Co-authored-by: carstenjacobsen <4585552+carstenjacobsen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on how-to guide for storage data migration
Fix Version Marker Pattern test examples to use proper contract context
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test examples in the Version Marker Pattern section accessed
env.storage()directly fromEnv::default()without a contract context, which panics at runtime. All storage reads/writes and helper calls must occur insideenv.as_contract(...).Changes
env.register(Contract, ())to obtain acontract_idenv.as_contract(&contract_id, || { ... })— including legacy v1 state injection,read_data,write_data, and version key readsenv.register+env.as_contractare requiredPattern now matches the Versioned Enum Pattern tests already present in the same guide.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.